junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Abri job amendment trigger is named after the OpenHousing job it amends 🟪

Browse source 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Daniel Roth 2026-07-03 16:26:15 +00:00
parent b5f7cc3548
commit 021e7c15bb
2 changed files with 18 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
etl/hubspot/hubspot_deal_differ.py
View file

@ -197,7 +197,7 @@ class HubspotDealDiffer:
return parse_hs_date(new_deal.get("confirmed_survey_date")) is not None
@staticmethod
def check_for_abri_survey_amendment(
def check_for_abri_job_amendment(
new_deal: Dict[str, str],
new_project: Optional[ProjectData],
old_deal: HubspotDealData,
@ -209,6 +209,10 @@ class HubspotDealDiffer:
if old_deal.confirmed_survey_date is None:
return False
# TODO: a cleared survey date (was set, now empty) still fires this
# check, but the amendoptiappt route cannot express a cancellation.
# Cancellation semantics (the "delete" action / canceljob route) need
# a deliberate decision before this trigger is wired to a consumer.
new_survey_date = parse_hs_date(new_deal.get("confirmed_survey_date"))
if old_deal.confirmed_survey_date != new_survey_date:
return True

26
etl/hubspot/tests/test_hubspot_deal_differ.py
View file

@ -548,12 +548,12 @@ def test_abri_job_logging__non_abri_project_id_with_abri_code__returns_false() -
assert result is False
# ===================================
# ABRI SURVEY AMENDMENT TRIGGER TESTS
# ===================================
# ================================
# ABRI JOB AMENDMENT TRIGGER TESTS
# ================================
def test_abri_survey_amendment__date_changed_on_abri_deal__returns_true() -> None:
def test_abri_job_amendment__date_changed_on_abri_deal__returns_true() -> None:
deal_id = uuid.uuid4()
# Arrange
@ -569,7 +569,7 @@ def test_abri_survey_amendment__date_changed_on_abri_deal__returns_true() -> Non
)
# Act
result = HubspotDealDiffer.check_for_abri_survey_amendment(
result = HubspotDealDiffer.check_for_abri_job_amendment(
new_deal=new_deal,
new_project=None,
old_deal=old_deal,
@ -579,7 +579,7 @@ def test_abri_survey_amendment__date_changed_on_abri_deal__returns_true() -> Non
assert result is True
def test_abri_survey_amendment__non_abri_deal__returns_false() -> None:
def test_abri_job_amendment__non_abri_deal__returns_false() -> None:
deal_id = uuid.uuid4()
# Arrange
@ -595,7 +595,7 @@ def test_abri_survey_amendment__non_abri_deal__returns_false() -> None:
)
# Act
result = HubspotDealDiffer.check_for_abri_survey_amendment(
result = HubspotDealDiffer.check_for_abri_job_amendment(
new_deal=new_deal,
new_project=None,
old_deal=old_deal,
@ -605,7 +605,7 @@ def test_abri_survey_amendment__non_abri_deal__returns_false() -> None:
assert result is False
def test_abri_survey_amendment__date_and_time_unchanged__returns_false() -> None:
def test_abri_job_amendment__date_and_time_unchanged__returns_false() -> None:
deal_id = uuid.uuid4()
# Arrange
@ -623,7 +623,7 @@ def test_abri_survey_amendment__date_and_time_unchanged__returns_false() -> None
)
# Act
result = HubspotDealDiffer.check_for_abri_survey_amendment(
result = HubspotDealDiffer.check_for_abri_job_amendment(
new_deal=new_deal,
new_project=None,
old_deal=old_deal,
@ -633,7 +633,7 @@ def test_abri_survey_amendment__date_and_time_unchanged__returns_false() -> None
assert result is False
def test_abri_survey_amendment__time_changed_on_abri_deal__returns_true() -> None:
def test_abri_job_amendment__time_changed_on_abri_deal__returns_true() -> None:
deal_id = uuid.uuid4()
# Arrange
@ -651,7 +651,7 @@ def test_abri_survey_amendment__time_changed_on_abri_deal__returns_true() -> Non
)
# Act
result = HubspotDealDiffer.check_for_abri_survey_amendment(
result = HubspotDealDiffer.check_for_abri_job_amendment(
new_deal=new_deal,
new_project=None,
old_deal=old_deal,
@ -661,7 +661,7 @@ def test_abri_survey_amendment__time_changed_on_abri_deal__returns_true() -> Non
assert result is True
def test_abri_survey_amendment__date_first_set_on_abri_deal__returns_false() -> None:
def test_abri_job_amendment__date_first_set_on_abri_deal__returns_false() -> None:
deal_id = uuid.uuid4()
# Arrange
@ -677,7 +677,7 @@ def test_abri_survey_amendment__date_first_set_on_abri_deal__returns_false() ->
)
# Act
result = HubspotDealDiffer.check_for_abri_survey_amendment(
result = HubspotDealDiffer.check_for_abri_job_amendment(
new_deal=new_deal,
new_project=None,
old_deal=old_deal,