From 0b8765481d78f39c25c8a22c26a6603bceb66ef8 Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Mon, 29 Jun 2026 22:01:33 +0000 Subject: [PATCH] =?UTF-8?q?Engine=20now=20matches=20lodged=2082=20on=20a?= =?UTF-8?q?=20PV=20cert=20(was=20under-rating=20to=2080)=20=F0=9F=9F=A9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Crediting the full-SAP lodged PV closes the 2-point under-rating on uprn 10023444324 — the engine now reproduces the accredited lodged value exactly. Co-Authored-By: Claude Opus 4.8 (1M context) --- datatypes/epc/domain/tests/test_from_sap_schema.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/datatypes/epc/domain/tests/test_from_sap_schema.py b/datatypes/epc/domain/tests/test_from_sap_schema.py index 574a1a61..7a682c8d 100644 --- a/datatypes/epc/domain/tests/test_from_sap_schema.py +++ b/datatypes/epc/domain/tests/test_from_sap_schema.py @@ -732,8 +732,9 @@ class TestFromSapSchema16_2: epc = EpcPropertyDataMapper.from_api_response(load("sap_17_0.json")) assert isinstance(epc, EpcPropertyData) assert epc.uprn == 10023444324 - # lodged 82; engine produces 80. - assert Sap10Calculator().calculate(epc).sap_score == 80 + # lodged 82; the engine now also produces 82 — the cert's lodged PV is + # credited (previously dropped by the full-SAP mapper, under-rating to 80). + assert Sap10Calculator().calculate(epc).sap_score == 82 def test_18_0_0_dispatches_via_full_sap_path(self) -> None: # SAP-Schema-18.0.0 is the full-SAP 17.1 shape; dispatched to