junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-08-03 05:18:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Honour dry_run on a queue-delivered rename request 🟩

Browse source 
Green on arrival: reading the request from the SQS record body is what
taking the task lane gave us. Verified the guard bites by restoring the
raw-event read, under which the "dry" run renames a live file.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Daniel Roth 2026-07-29 08:59:45 +00:00
parent 694881c110
commit 1213b80e3f
1 changed files with 35 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
tests/applications/sharepoint_renamer/test_handler.py
View file

@ -197,3 +197,38 @@ def test_completed_subtask_carries_the_run_summary(
"failed": [],
}
}
# ---------------------------------------------------------------------------
# A queue-delivered dry run is actually a dry run
# ---------------------------------------------------------------------------
def test_dry_run_in_an_sqs_record_body_renames_nothing(
harness: Harness, tmp_path: Path, monkeypatch: pytest.MonkeyPatch
) -> None:
"""The request must come from the SQS *record body*, not the raw Lambda
event. Validating the raw event leaves every unknown key ignored, so
``dry_run`` fell back to False and every queue-triggered run renamed live
files — the flag only ever worked on a direct invoke."""
# Arrange
sharepoint = FakeSharepoint(_one_property_site(_file("Survey.pdf", "id-1")))
_install(monkeypatch, tmp_path, sharepoint)
# Act
result = _handler(harness)(
_sqs_event({"sharepoint_site": SITE, "dry_run": True}), None
)
# Assert
assert sharepoint.renamed == []
assert harness.subtasks.get(_subtask_id(result)).outputs == {
"result": {
"renamed": 0,
"would_rename": 1,
"skipped_already_canonical": 0,
"skipped_images": 0,
"missing_folders": [],
"failed": [],
}
}