From 18ea95b67d3e15c41dbe57fa4228bd21a762719b Mon Sep 17 00:00:00 2001
From: Jun-te Kim <juntekim@googlemail.com>
Date: Tue, 12 May 2026 12:34:17 +0000
Subject: [PATCH] added env variables for boto

---
 .../backend/install-claude-skills.sh          | 14 ------
 .github/workflows/unit_tests.yml              |  3 ++
 backend/address2UPRN/tests/test_csv.py        | 47 ++++---------------
 3 files changed, 13 insertions(+), 51 deletions(-)
 delete mode 100755 .devcontainer/backend/install-claude-skills.sh

diff --git a/.devcontainer/backend/install-claude-skills.sh b/.devcontainer/backend/install-claude-skills.sh
deleted file mode 100755
index a54f69e0..00000000
--- a/.devcontainer/backend/install-claude-skills.sh
+++ /dev/null
@@ -1,14 +0,0 @@
-#!/usr/bin/env bash
-# Run this in an existing container to install the mattpocock skills
-# without rebuilding the image. New containers get them automatically via Dockerfile.
-set -euo pipefail
-
-echo "Installing Claude Code skills (mattpocock/skills)..."
-
-npx skills@latest add --global --yes mattpocock/skills/grill-me
-npx skills@latest add --global --yes mattpocock/skills/to-prd
-npx skills@latest add --global --yes mattpocock/skills/ubiquitous-language
-npx skills@latest add --global --yes mattpocock/skills/tdd
-npx skills@latest add --global --yes mattpocock/skills/improve-codebase-architecture
-
-echo "Done. Available: /grill-me  /to-prd  /ubiquitous-language  /tdd  /improve-codebase-architecture"
diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml
index e1f4fb48..fa4fdf2a 100644
--- a/.github/workflows/unit_tests.yml
+++ b/.github/workflows/unit_tests.yml
@@ -51,6 +51,9 @@ jobs:
             -e EPC_AUTH_TOKEN=${{ secrets.DEV_EPC_AUTH_TOKEN }} \
             -e OPEN_EPC_API_TOKEN=${{ secrets.DEV_OPEN_EPC_API_TOKEN }} \
             -e HUBSPOT_API_KEY=${{ secrets.HUBSPOT_API_KEY }} \
+            -e AWS_ACCESS_KEY_ID=${{ secrets.DEV_AWS_ACCESS_KEY_ID }} \
+            -e AWS_SECRET_ACCESS_KEY=${{ secrets.DEV_AWS_SECRET_ACCESS_KEY }} \
+            -e AWS_DEFAULT_REGION=${{ secrets.DEV_AWS_REGION }} \
             -e DB_HOST=localhost \
             -e DB_NAME=test \
             -e DB_USERNAME=test \
diff --git a/backend/address2UPRN/tests/test_csv.py b/backend/address2UPRN/tests/test_csv.py
index d8f54c39..70e7a9f9 100644
--- a/backend/address2UPRN/tests/test_csv.py
+++ b/backend/address2UPRN/tests/test_csv.py
@@ -1,54 +1,25 @@
 # tests/test_address_to_uprn_csv.py
 
 import csv
-import json
 import pytest
-from datetime import date
 from pathlib import Path
 from backend.address2UPRN.main import get_uprn
 
 FIXTURE_PATH = Path(__file__).parent / "test_data.csv"
-SIDECAR_PATH = Path(__file__).parent / "test_lodgement_dates.json"
-NEW_API_CUTOFF = date(2012, 1, 1)
-
-
-def _load_sidecar() -> dict:
-    if SIDECAR_PATH.exists():
-        return json.loads(SIDECAR_PATH.read_text())
-    return {}
 
 
 def load_test_cases():
-    sidecar = _load_sidecar()
     with open(FIXTURE_PATH, newline="", encoding="utf-8") as f:
         reader = csv.DictReader(f)
-        cases = []
-        for row in reader:
-            key = f"{row['User Input']}|{row['Postcode']}"
-            entry = sidecar.get(key, {})
-            lodgement_date = entry.get("lodgement_date")
-
-            marks = []
-            if lodgement_date:
-                parsed = date.fromisoformat(lodgement_date[:10])
-                if parsed < NEW_API_CUTOFF:
-                    marks.append(
-                        pytest.mark.xfail(
-                            reason=f"EPC lodged {lodgement_date} — predates new API coverage (Jan 2012)",
-                            strict=False,
-                        )
-                    )
-
-            cases.append(
-                pytest.param(
-                    row["User Input"],
-                    row["Postcode"],
-                    row["Manual UPRN Code"],
-                    id=f'{row["User Input"]} [{row["Postcode"]}]',
-                    marks=marks,
-                )
+        return [
+            pytest.param(
+                row["User Input"],
+                row["Postcode"],
+                row["Manual UPRN Code"],
+                id=f'{row["User Input"]} [{row["Postcode"]}]',
             )
-        return cases
+            for row in reader
+        ]
 
 
 @pytest.mark.parametrize(
@@ -60,6 +31,8 @@ def test_uprn_resolution_matches_manual(
     postcode: str,
     expected_uprn: str,
 ):
+    from utils.logger import setup_logger
+
     uprn = get_uprn(user_input, postcode)
     if uprn:
         assert uprn == expected_uprn