junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

updated conservation area conditions in wall recommendations to check restricted measures

Browse source
This commit is contained in:
Khalim Conn-Kowlessar 2023-10-05 18:25:53 +01:00
parent 2b783c8d1a
commit 2d85e79bd4
1 changed files with 3 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
recommendations/WallRecommendations.py
View file

@ -46,11 +46,9 @@ class WallRecommendations(Definitions):
def __init__(
self,
property_instance: Property,
total_floor_area_group_decile: str,
materials: List
):
self.property = property_instance
self.total_floor_area_group_decile = total_floor_area_group_decile
# For audit purposes, when estimating u values we'll store it
self.estimated_u_value = None
@ -65,9 +63,9 @@ class WallRecommendations(Definitions):
This method check available data, to determine if a property is suitable for external wall insulation
"""
# Current logic: If the property is in a conservation area or a flat, it is not suitable for EWI
if (self.property.in_conservation_area in ["in_conversation_area"]) or \
(self.property.data["property-type"].lower() == "flat"):
# Current logic: If the property is in a conservation area/heritage building/listed building or a flat,
# it is not suitable for EWI
if (not self.property.restricted_measures) or (self.property.data["property-type"].lower() == "flat"):
return False
return True
@ -91,10 +89,6 @@ class WallRecommendations(Definitions):
if self.property.walls["thermal_transmittance_unit"] != self.U_VALUE_UNIT:
raise NotImplementedError("Haven't handled the case of other u value units yet")
# TODO: It's worth thinking about this logic because depending on when epc were built,
# they're likely to be of a certain standard. E.g. epc built within a certain time
# period are likely to have cavity walls
# We can't detect it's a cavity wall, but it was built after 1990 so likely built with insulation already
# + it already has a U-value WORSE than the building regulations, so we recommend either internal or
# external wall insulation