From 302861309c0aeb1de5a537c23f6d12c72b840ee2 Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Tue, 7 Jul 2026 11:38:18 +0000 Subject: [PATCH] =?UTF-8?q?Numeric=20RdSAP=20property-type=20codes=20map?= =?UTF-8?q?=20to=20their=20labels=20=F0=9F=9F=A5?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Fable 5 --- .../app/modelling/test_property_filters.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/tests/backend/app/modelling/test_property_filters.py b/tests/backend/app/modelling/test_property_filters.py index d7c77212a..22d7a204b 100644 --- a/tests/backend/app/modelling/test_property_filters.py +++ b/tests/backend/app/modelling/test_property_filters.py @@ -177,6 +177,25 @@ def test_epc_property_type_prefers_lodged_over_predicted(db_engine: Engine) -> N assert [p.property_id for p in resolved] == [predicted_only] +def test_epc_numeric_property_type_codes_map_to_labels(db_engine: Engine) -> None: + # arrange — RdSAP code 1 = Bungalow + with Session(db_engine) as session: + coded = _seed_property(session, portfolio_id=814) + _seed_epc(session, property_id=coded, property_type="1") + _house = _seed_property(session, portfolio_id=814) + _seed_epc(session, property_id=_house, property_type="0") + + # act + resolved = resolve_filtered_property_ids( + session, + portfolio_id=814, + filters=PropertyGroupFilters(property_types=["Bungalow"]), + ) + + # assert + assert [p.property_id for p in resolved] == [coded] + + def test_postcode_filter_matches_exactly(db_engine: Engine) -> None: # arrange with Session(db_engine) as session: