From 31fc7ee1151c9db7993a5b2251a80e431f5dd4fd Mon Sep 17 00:00:00 2001 From: Daniel Roth Date: Wed, 8 Jul 2026 14:37:15 +0000 Subject: [PATCH] =?UTF-8?q?use=20unsuccesseful=20outcoems=20constant=20dir?= =?UTF-8?q?ectly=20in=20hubspot=20deal=20differ=20=F0=9F=9F=AA?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- etl/hubspot/hubspot_deal_differ.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/etl/hubspot/hubspot_deal_differ.py b/etl/hubspot/hubspot_deal_differ.py index 9e2bd88fd..def629947 100644 --- a/etl/hubspot/hubspot_deal_differ.py +++ b/etl/hubspot/hubspot_deal_differ.py @@ -16,7 +16,6 @@ class HubspotDealDiffer: RETROFIT_DESIGN_COMPLETE = "uploaded" LODGEMENT_COMPLETE: List[str] = ["lodgement complete", "measures lodged"] ABANDONMENT_ATTEMPTS_THRESHOLD = 3 - NEGATIVE_OUTCOMES = UNSUCCESSFUL_OUTCOMES # Verified against the portal (2026-07-07): Abri stock-condition deals # carry no project association, so the project_code match is the branch # that fires in production; the id below is the project object id @@ -328,7 +327,7 @@ class HubspotDealDiffer: ): return False - return (outcome or "").lower() in HubspotDealDiffer.NEGATIVE_OUTCOMES + return (outcome or "").lower() in UNSUCCESSFUL_OUTCOMES @staticmethod def _is_abri_condition_deal(