junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Age band conditions within one band; the floor-area band widens to ±20% 🟥

Browse source 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-07-06 11:06:45 +00:00
parent 1a11d0b900
commit 355c1e7d2f
1 changed files with 44 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
tests/domain/epc_prediction/test_comparable_properties.py
View file

@ -243,21 +243,24 @@ def test_historic_main_fuel_conditions_the_cohort() -> None:
}
def test_floor_area_band_keeps_comparables_within_5_percent() -> None:
# Arrange — the expired cert observed 100 m²; the band is ±5% (ADR-0054):
# 96 and 104.9 are in, 90 and 111 are out.
def test_floor_area_band_keeps_comparables_within_20_percent() -> None:
# Arrange — the expired cert observed 100 m²; the band is ±20% (ADR-0054 as
# amended: the 439-pair harness put historic-vs-new TFA agreement at only
# 45% within ±5% but 82% within ±20% — a coarse dwelling-size filter, not a
# precision match): 96, 118 and 84 are in, 125 and 79 are out.
target = PredictionTarget(
postcode="LS6 1AA", property_type="2", total_floor_area_m2=100.0
)
candidates = [
_comparable(property_type="2", total_floor_area_m2=96.0, certificate_number="A"),
_comparable(
property_type="2", total_floor_area_m2=104.9, certificate_number="B"
property_type="2", total_floor_area_m2=118.0, certificate_number="B"
),
_comparable(property_type="2", total_floor_area_m2=90.0, certificate_number="X"),
_comparable(property_type="2", total_floor_area_m2=84.0, certificate_number="C"),
_comparable(
property_type="2", total_floor_area_m2=111.0, certificate_number="Y"
property_type="2", total_floor_area_m2=125.0, certificate_number="X"
),
_comparable(property_type="2", total_floor_area_m2=79.0, certificate_number="Y"),
]
# Act
@ -266,7 +269,41 @@ def test_floor_area_band_keeps_comparables_within_5_percent() -> None:
)
# Assert
assert {c.certificate_number for c in result.members} == {"A", "B"}
assert {c.certificate_number for c in result.members} == {"A", "B", "C"}
def test_historic_age_band_conditions_within_one_band() -> None:
# Arrange — the expired cert observed band C, but assessors re-band ±1
# constantly (harness: 52% exact agreement, 90% within one band), so the
# filter keeps the band NEIGHBOURHOOD: B/C/D match, G does not (ADR-0054 as
# amended).
target = PredictionTarget(
postcode="LS6 1AA", property_type="2", construction_age_band="C"
)
near = ["B", "C", "D", "D", "B"]
candidates = [
_comparable(
property_type="2",
construction_age_band=band,
certificate_number=f"N{i}",
)
for i, band in enumerate(near)
] + [
_comparable(
property_type="2", construction_age_band="G", certificate_number=f"G{i}"
)
for i in range(2)
]
# Act
result: ComparableProperties = select_comparables(
target, candidates, minimum_cohort=5
)
# Assert — the five band-neighbourhood comparables survive; band G drops.
assert {c.certificate_number for c in result.members} == {
"N0", "N1", "N2", "N3", "N4"
}
def test_floor_area_band_relaxes_when_too_few_match() -> None: