junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Write total trickle vent area to column O; shift door columns to Q/R/S/T 🟥

Browse source 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Daniel Roth 2026-06-30 09:37:55 +00:00
parent fad7bd6e96
commit 367fd3664b
1 changed files with 12 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
tests/domain/magicplan/test_ventilation_audit.py
View file

@ -135,7 +135,7 @@ def test_writes_window_opening_data_to_columns_J_K_L() -> None:
assert sheet["L6"].value == pytest.approx(0.5)
def test_writes_trickle_vent_data_to_columns_N_and_O() -> None:
def test_writes_trickle_vent_count_to_N_and_total_area_to_O() -> None:
# Arrange
plan = _make_plan(num_rooms=1, num_windows_per_room=1, num_doors_per_room=0)
sheet = _blank_sheet()
@ -144,11 +144,11 @@ def test_writes_trickle_vent_data_to_columns_N_and_O() -> None:
populate_sheet(sheet, plan)
# Assert
assert sheet["N6"].value == 1000
assert sheet["O6"].value == 2
assert sheet["N6"].value == 2
assert sheet["O6"].value == 1000
def test_writes_door_room_name_to_column_R() -> None:
def test_writes_door_room_name_to_column_Q() -> None:
# Arrange
plan = _make_plan(num_rooms=1, num_windows_per_room=0, num_doors_per_room=1)
sheet = _blank_sheet()
@ -157,10 +157,10 @@ def test_writes_door_room_name_to_column_R() -> None:
populate_sheet(sheet, plan)
# Assert
assert sheet["R6"].value == "Room 0"
assert sheet["Q6"].value == "Room 0"
def test_writes_door_dimensions_to_columns_S_and_T() -> None:
def test_writes_door_dimensions_to_columns_R_and_S() -> None:
# Arrange
plan = _make_plan(num_rooms=1, num_windows_per_room=0, num_doors_per_room=1)
sheet = _blank_sheet()
@ -169,8 +169,8 @@ def test_writes_door_dimensions_to_columns_S_and_T() -> None:
populate_sheet(sheet, plan)
# Assert
assert sheet["S6"].value == 800.0
assert sheet["T6"].value == 10.0
assert sheet["R6"].value == 800.0
assert sheet["S6"].value == 10.0
def test_writes_zeros_when_window_has_no_ventilation() -> None:
@ -186,8 +186,8 @@ def test_writes_zeros_when_window_has_no_ventilation() -> None:
assert sheet["J6"].value == 0
assert sheet["K6"].value == 0
assert sheet["L6"].value == 0
assert sheet["N6"].value == 0
assert sheet["O6"].value == 0
assert sheet["N6"].value == 0 # count
assert sheet["O6"].value == 0 # total area
def test_writes_zeros_when_door_has_no_ventilation() -> None:
@ -200,7 +200,7 @@ def test_writes_zeros_when_door_has_no_ventilation() -> None:
populate_sheet(sheet, plan)
# Assert
assert sheet["T6"].value == 0
assert sheet["S6"].value == 0
_TEMPLATE_PATH = (
@ -220,4 +220,4 @@ def test_real_template_survives_18_doors() -> None:
populate_sheet(sheet, plan)
assert sheet["R23"].value == "Room 17"
assert sheet["Q23"].value == "Room 17"