From 3f2992bcb0edb73393a3daa6e660997936d02853 Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Mon, 19 Jun 2023 13:50:10 +0100 Subject: [PATCH] corrected tests --- model_data/app.py | 1 + model_data/tests/test_mainheat_controls_attributes.py | 5 ----- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/model_data/app.py b/model_data/app.py index 3e755555..f318a13f 100644 --- a/model_data/app.py +++ b/model_data/app.py @@ -78,6 +78,7 @@ def handler(): # https://docs.google.com/spreadsheets/d/1ek9ItDv7xHwFm_FK6B0PyOBwvi6U4qRPuncBsVlCHUA/edit#gid=0 cleaner.cleaned.keys() floors = pd.DataFrame(cleaner.cleaned['floor-description']) + walls = pd.DataFrame(cleaner.cleaned['walls-description']) hotwater = pd.DataFrame(cleaner.cleaned['hotwater-description']) mainheat = pd.DataFrame(cleaner.cleaned["mainheat-description"]) diff --git a/model_data/tests/test_mainheat_controls_attributes.py b/model_data/tests/test_mainheat_controls_attributes.py index 15a99fed..e06aa4e9 100644 --- a/model_data/tests/test_mainheat_controls_attributes.py +++ b/model_data/tests/test_mainheat_controls_attributes.py @@ -11,10 +11,6 @@ class TestMainHeatControlAttributes: attr = MainheatControlAttributes(valid_description) assert attr.description == valid_description.lower() - # Test initialization with an empty description - with pytest.raises(ValueError): - MainheatControlAttributes('') - # Test initialization with a description that contains none of the keywords with pytest.raises(ValueError): MainheatControlAttributes('description without keywords') @@ -32,7 +28,6 @@ class TestMainHeatControlAttributes: def test_invalid_description(self): # Test that invalid descriptions raise a ValueError invalid_descriptions = [ - "", "invalid description", "description with no known heating control types", ]