From 3f723785e48f5a06df5f725438d286331fd74037 Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Fri, 21 Jul 2023 10:34:05 +0100 Subject: [PATCH] handling welsh wall cases --- model_data/epc_attributes/WallAttributes.py | 10 ++++++++++ .../tests/test_data/test_wall_attributes_cases.py | 6 ++++++ 2 files changed, 16 insertions(+) diff --git a/model_data/epc_attributes/WallAttributes.py b/model_data/epc_attributes/WallAttributes.py index 5b8226dd..886d2956 100644 --- a/model_data/epc_attributes/WallAttributes.py +++ b/model_data/epc_attributes/WallAttributes.py @@ -7,12 +7,22 @@ class WallAttributes(BaseUtility): WALL_TYPES = ['cavity wall', 'filled cavity', 'solid brick', 'system built', 'timber frame', 'granite or whinstone', 'as built', 'cob', 'assumed', 'sandstone or limestone'] + WELSH_TEXT = { + "Briciau solet, fel yGÇÖu hadeiladwyd, dim inswleiddio (rhagdybiaeth)": + "Solid brick, as built, no insulation (assumed)", + } + def __init__(self, description: str): """ :param description: Description of the walls. """ self.description: str = description + translation = self.WELSH_TEXT.get(self.description) + if translation: + self.nodata = False + self.description = translation + self.nodata = not description or description in self.DATA_ANOMALY_MATCHES def process(self) -> Dict[str, Union[float, str, bool, None]]: diff --git a/model_data/tests/test_data/test_wall_attributes_cases.py b/model_data/tests/test_data/test_wall_attributes_cases.py index e64ed535..162ebc1f 100644 --- a/model_data/tests/test_data/test_wall_attributes_cases.py +++ b/model_data/tests/test_data/test_wall_attributes_cases.py @@ -684,5 +684,11 @@ wall_cases = [ 'thermal_transmittance_unit': None, 'is_cavity_wall': False, 'is_filled_cavity': False, 'is_solid_brick': False, 'is_system_built': False, 'is_timber_frame': True, 'is_granite_or_whinstone': False, 'is_as_built': False, 'is_cob': False, 'is_assumed': False, 'is_sandstone_or_limestone': False, 'insulation_thickness': 'above average', + 'external_insulation': False, 'internal_insulation': False}, + {'original_description': 'Briciau solet, fel yGÇÖu hadeiladwyd, dim inswleiddio (rhagdybiaeth)', + 'thermal_transmittance': None, + 'thermal_transmittance_unit': None, 'is_cavity_wall': False, 'is_filled_cavity': False, 'is_solid_brick': True, + 'is_system_built': False, 'is_timber_frame': False, 'is_granite_or_whinstone': False, 'is_as_built': True, + 'is_cob': False, 'is_assumed': True, 'is_sandstone_or_limestone': False, 'insulation_thickness': 'none', 'external_insulation': False, 'internal_insulation': False} ]