From 41d62ce2b2fd7dd63917b9551d42b72e14b84cd6 Mon Sep 17 00:00:00 2001
From: Daniel Roth <daniel_roth@hotmail.co.uk>
Date: Fri, 3 Jul 2026 10:10:26 +0000
Subject: [PATCH] =?UTF-8?q?Abri=20deal=20abandonment=20requires=20a=20nega?=
 =?UTF-8?q?tive=20outcome=20=F0=9F=9F=A5?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---
 etl/hubspot/tests/test_hubspot_deal_differ.py | 77 +++++++++++++++++++
 1 file changed, 77 insertions(+)

diff --git a/etl/hubspot/tests/test_hubspot_deal_differ.py b/etl/hubspot/tests/test_hubspot_deal_differ.py
index 5699262fb..754385c5b 100644
--- a/etl/hubspot/tests/test_hubspot_deal_differ.py
+++ b/etl/hubspot/tests/test_hubspot_deal_differ.py
@@ -966,6 +966,83 @@ def test_abri_deal_abandonment__fewer_than_three_parseable_attempts__returns_fal
     assert result is False
 
 
+@pytest.mark.parametrize(
+    "new_overrides",
+    [
+        {"outcome": "Surveyed"},
+        {"outcome": ""},
+        {},
+    ],
+)
+def test_abri_deal_abandonment__outcome_not_negative__returns_false(
+    new_overrides: Dict[str, str],
+) -> None:
+    deal_id = uuid.uuid4()
+
+    # Arrange
+    old_deal = make_old_deal(
+        id=deal_id,
+        project_code="Abri Condition",
+        outcome=None,
+    )
+    new_deal = make_new_deal(
+        deal_id,
+        project_code="Abri Condition",
+        number_of_attempts="3",
+        **new_overrides,
+    )
+
+    # Act
+    result = HubspotDealDiffer.check_for_abri_deal_abandonment(
+        new_deal=new_deal,
+        new_project=None,
+        old_deal=old_deal,
+    )
+
+    # Assert
+    assert result is False
+
+
+@pytest.mark.parametrize(
+    "outcome",
+    [
+        "No Answer",
+        "Cancelled",
+        "No Show",
+        "Tenant Refusal",
+        "Not Viable",
+        "NO ANSWER",
+    ],
+)
+def test_abri_deal_abandonment__each_negative_outcome__returns_true(
+    outcome: str,
+) -> None:
+    deal_id = uuid.uuid4()
+
+    # Arrange
+    old_deal = make_old_deal(
+        id=deal_id,
+        project_code="Abri Condition",
+        outcome=None,
+    )
+    new_deal = make_new_deal(
+        deal_id,
+        project_code="Abri Condition",
+        number_of_attempts="3",
+        outcome=outcome,
+    )
+
+    # Act
+    result = HubspotDealDiffer.check_for_abri_deal_abandonment(
+        new_deal=new_deal,
+        new_project=None,
+        old_deal=old_deal,
+    )
+
+    # Assert
+    assert result is True
+
+
 # =======================
 # DB UPDATE TRIGGER TESTS
 # =======================