Renamer warns once per property only after all roots miss 🟪

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Daniel Roth 2026-07-03 11:19:34 +00:00
parent 213cd92998
commit 46ed8bfe86

View file

@ -87,21 +87,26 @@ class SharepointRenamerOrchestrator:
)
for row in reader:
uprn = row["UPRN"].strip()
address = row["Address"].strip()
postcode = row["Postcode"].strip()
for root in roots:
folder_path = (
f"{root}/{address}, {postcode}"
f"/{SharepointSubfolders.ASSESSMENT.value}/{ASSESSMENT_SUBFOLDER}"
)
if self._process_folder(folder_path, uprn, address, postcode):
break
else:
logger.warning(
f"Missing folder for UPRN {uprn} in any root: "
f"{address}, {postcode}"
)
self._process_row(
roots,
uprn=row["UPRN"].strip(),
address=row["Address"].strip(),
postcode=row["Postcode"].strip(),
)
def _process_row(
self, roots: list[str], uprn: str, address: str, postcode: str
) -> None:
for root in roots:
folder_path = (
f"{root}/{address}, {postcode}"
f"/{SharepointSubfolders.ASSESSMENT.value}/{ASSESSMENT_SUBFOLDER}"
)
if self._process_folder(folder_path, uprn, address, postcode):
return
logger.warning(
f"Missing folder for UPRN {uprn} in any root: {address}, {postcode}"
)
def _process_folder(
self, folder_path: str, uprn: str, address: str, postcode: str