From 5286e2a2a20705003d70889bd58bc80254fe4d90 Mon Sep 17 00:00:00 2001 From: Daniel Roth Date: Tue, 7 Jul 2026 12:31:07 +0000 Subject: [PATCH] =?UTF-8?q?The=20job=20number=20is=20stored=20in=20the=20c?= =?UTF-8?q?lient=5Fbooking=5Freference=20column=20=F0=9F=9F=A9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Fable 5 --- backend/app/db/models/hubspot_deal_data.py | 11 ++++++++--- .../test_deal_database_postgres_gateway.py | 5 +++-- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/backend/app/db/models/hubspot_deal_data.py b/backend/app/db/models/hubspot_deal_data.py index c221cbcdc..eab0e7b75 100644 --- a/backend/app/db/models/hubspot_deal_data.py +++ b/backend/app/db/models/hubspot_deal_data.py @@ -2,7 +2,7 @@ import uuid from sqlmodel import SQLModel, Field, Column, text from datetime import datetime from typing import Optional -from sqlalchemy import DateTime +from sqlalchemy import DateTime, String from sqlalchemy.sql import func @@ -71,8 +71,13 @@ class HubspotDealData(SQLModel, table=True): confirmed_survey_time: Optional[str] = Field(default=None) surveyed_date: Optional[datetime] = Field(default=None) design_type: Optional[str] = Field(default=None) - # OpenHousing job number; HubSpot property ID is client_booking_reference. - job_no: Optional[str] = Field(default=None) + # OpenHousing job number; stored under the same name as the HubSpot + # property that carries it (client_booking_reference) — the column is + # created by the frontend repo's drizzle migration. Only the domain + # calls it job_no. + job_no: Optional[str] = Field( + default=None, sa_column=Column("client_booking_reference", String) + ) survey_type: Optional[str] = Field(default=None) measures_for_pibi_ordered: Optional[str] = Field(default=None) diff --git a/tests/repositories/hubspot_deals/test_deal_database_postgres_gateway.py b/tests/repositories/hubspot_deals/test_deal_database_postgres_gateway.py index aaa96733b..5e6a768ed 100644 --- a/tests/repositories/hubspot_deals/test_deal_database_postgres_gateway.py +++ b/tests/repositories/hubspot_deals/test_deal_database_postgres_gateway.py @@ -63,11 +63,12 @@ def test_the_job_no_is_stored_in_the_client_booking_reference_column( gateway.record_job_no(deal_id=DEAL_ID, job_no="AD0226519") # Assert - stored = session.exec( # type: ignore[reportCallOverload] + stored = session.connection().execute( text( "select client_booking_reference from hubspot_deal_data " "where deal_id = :deal_id" - ).bindparams(deal_id=DEAL_ID) + ), + {"deal_id": DEAL_ID}, ).one() assert stored[0] == "AD0226519"