From 5597a8b87eb6ce36eef3aa4045b7948ce36f377c Mon Sep 17 00:00:00 2001
From: Khalim Conn-Kowlessar <kconnkowlessar@gmail.com>
Date: Fri, 5 Jun 2026 10:26:17 +0000
Subject: [PATCH] review: bind test inputs in Arrange for the
 wall-insulation-thickness tests

PR feedback (dancafc): the `_api_resolve_wall_insulation_thickness` tests
passed literals straight into the Act call. Bind them as named variables
in Arrange (`lodged_thickness`, `measured_value_mm`, `ni_lodgement`) and
have the asserts reference those names, so the Act line reads
declaratively and the inputs/expectations are stated once. Applied to all
three tests in the class. No behaviour change; tests pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 .../domain/tests/test_from_rdsap_schema.py    | 27 ++++++++++++++-----
 1 file changed, 21 insertions(+), 6 deletions(-)

diff --git a/datatypes/epc/domain/tests/test_from_rdsap_schema.py b/datatypes/epc/domain/tests/test_from_rdsap_schema.py
index 5a4796a5..c1ef3ad3 100644
--- a/datatypes/epc/domain/tests/test_from_rdsap_schema.py
+++ b/datatypes/epc/domain/tests/test_from_rdsap_schema.py
@@ -717,11 +717,16 @@ class TestApiResolveWallInsulationThickness:
             _api_resolve_wall_insulation_thickness,
         )
 
+        lodged_thickness = "measured"
+        measured_value_mm = 100
+
         # Act
-        resolved = _api_resolve_wall_insulation_thickness("measured", 100)
+        resolved = _api_resolve_wall_insulation_thickness(
+            lodged_thickness, measured_value_mm
+        )
 
         # Assert
-        assert resolved == 100
+        assert resolved == measured_value_mm
 
     def test_non_measured_lodgement_passes_through_unchanged(self) -> None:
         # Arrange
@@ -729,12 +734,17 @@ class TestApiResolveWallInsulationThickness:
             _api_resolve_wall_insulation_thickness,
         )
 
+        ni_lodgement = "NI"
+        measured_value_mm = 100
+
         # Act
-        ni: object = _api_resolve_wall_insulation_thickness("NI", 100)
+        ni: object = _api_resolve_wall_insulation_thickness(
+            ni_lodgement, measured_value_mm
+        )
         none_thk: object = _api_resolve_wall_insulation_thickness(None, None)
 
         # Assert
-        assert ni == "NI"
+        assert ni == ni_lodgement
         assert none_thk is None
 
     def test_measured_without_value_passes_through(self) -> None:
@@ -743,11 +753,16 @@ class TestApiResolveWallInsulationThickness:
             _api_resolve_wall_insulation_thickness,
         )
 
+        lodged_thickness = "measured"
+        measured_value_mm = None
+
         # Act
-        resolved: object = _api_resolve_wall_insulation_thickness("measured", None)
+        resolved: object = _api_resolve_wall_insulation_thickness(
+            lodged_thickness, measured_value_mm
+        )
 
         # Assert
-        assert resolved == "measured"
+        assert resolved == lodged_thickness
 
 
 # ---------------------------------------------------------------------------