From 586bb27d95973b0af6ee19eac27daf71316cc4ee Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Sat, 30 May 2026 20:25:47 +0000 Subject: [PATCH] =?UTF-8?q?Slice=20S0380.117:=20re-pin=20golden=20PE=20res?= =?UTF-8?q?iduals=20for=200240=20+=206035=20(track=20=C2=A715)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Slice S0380.116 rounded `A_RR_shell = 12.5 × √(A_RR_floor / 1.5)` to 2 d.p. per RdSAP 10 §15 (p.66). Two certs in the golden corpus have RR-driven cascade paths that fire this rounding: 0240 (TFA 118, age J, RR on BP[0]): PE +12.4941 → +12.4933 6035 (TFA 128, age A, RR + gas combi): PE +46.0936 → +46.0952 CO2 deltas on both are sub-1e-4 (display-precision noise) so those pins stay. All 51 cohort-2 certs are unchanged — their A_RR_shell paths either bypass the Simplified branch (Detailed RR with `slope`/`flat_ceiling` roof lodgements) or have no RR. Per [[feedback-golden-residuals-near-zero]] re-pin to track new cascade output rather than absorb the drift into the test tolerance. The ±0.01 PE / ±0.001 CO2 absolute tolerances on the pin stay; what changes is the expected residual value. Test still passes at ±0.0000 drift on all 53 certs post-repin. Co-Authored-By: Claude Opus 4.7 --- domain/sap10_calculator/rdsap/tests/test_golden_fixtures.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/domain/sap10_calculator/rdsap/tests/test_golden_fixtures.py b/domain/sap10_calculator/rdsap/tests/test_golden_fixtures.py index 47e239b9..9ef94470 100644 --- a/domain/sap10_calculator/rdsap/tests/test_golden_fixtures.py +++ b/domain/sap10_calculator/rdsap/tests/test_golden_fixtures.py @@ -75,7 +75,7 @@ _EXPECTATIONS: tuple[_GoldenExpectation, ...] = ( cert_number="0240-0200-5706-2365-8010", actual_sap=73, expected_sap_resid=-14, - expected_pe_resid_kwh_per_m2=+12.4941, + expected_pe_resid_kwh_per_m2=+12.4933, expected_co2_resid_tonnes_per_yr=+0.6957, notes=( "Detached house, TFA 118, age J, oil boiler PCDB-listed + PV + " @@ -145,7 +145,7 @@ _EXPECTATIONS: tuple[_GoldenExpectation, ...] = ( cert_number="6035-7729-2309-0879-2296", actual_sap=70, expected_sap_resid=-6, - expected_pe_resid_kwh_per_m2=+46.0936, + expected_pe_resid_kwh_per_m2=+46.0952, expected_co2_resid_tonnes_per_yr=+1.0495, notes=( "Mid-terrace, TFA 128, age A, gas combi Table 4b code 104. "