From 676022a4c054d7301b1d7542b582fadbb63705b4 Mon Sep 17 00:00:00 2001
From: Daniel Roth <daniel_roth@hotmail.co.uk>
Date: Fri, 8 May 2026 12:53:37 +0000
Subject: [PATCH] =?UTF-8?q?Fix=20coordination/design=20field=20names=20and?=
 =?UTF-8?q?=20add=20MagicPlan=20trigger=20to=20HubspotDealDiffer=20?=
 =?UTF-8?q?=F0=9F=9F=A5?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 etl/hubspot/hubspot_deal_differ.py            |  6 ++
 etl/hubspot/tests/test_hubspot_deal_differ.py | 76 ++++++++++++++++++-
 2 files changed, 79 insertions(+), 3 deletions(-)

diff --git a/etl/hubspot/hubspot_deal_differ.py b/etl/hubspot/hubspot_deal_differ.py
index 9e7069fc..a53df4f7 100644
--- a/etl/hubspot/hubspot_deal_differ.py
+++ b/etl/hubspot/hubspot_deal_differ.py
@@ -194,6 +194,12 @@ class HubspotDealDiffer:
             and new_status != old_deal.design_status
         )
 
+    @staticmethod
+    def check_for_magicplan_trigger(
+        new_deal: Dict[str, str], old_deal: HubspotDealData
+    ) -> bool:
+        raise NotImplementedError
+
     @staticmethod
     def _lodgement_completed(
         new_deal: Dict[str, str], old_deal: HubspotDealData
diff --git a/etl/hubspot/tests/test_hubspot_deal_differ.py b/etl/hubspot/tests/test_hubspot_deal_differ.py
index 0523c982..273a82a0 100644
--- a/etl/hubspot/tests/test_hubspot_deal_differ.py
+++ b/etl/hubspot/tests/test_hubspot_deal_differ.py
@@ -109,7 +109,7 @@ def test_pashub_trigger__coordination_completed_and_pashub_link_set__returns_tru
     new_deal = make_new_deal(
         deal_id,
         pashub_link="www.google.co.uk",
-        coordination_status=coordination_status,
+        **{"coordination_status__stage_1_": coordination_status},
     )
 
     assert (
@@ -156,7 +156,7 @@ def test_pashub_trigger__design_completed_and_pashub_link_set__returns_true() ->
     new_deal = make_new_deal(
         deal_id,
         pashub_link="www.google.co.uk",
-        design_status="uploaded",
+        retrofit_design_status="uploaded",
     )
 
     assert (
@@ -177,7 +177,7 @@ def test_pashub_trigger__design_completed_and_pashub_link_not_set__returns_false
 
     new_deal = make_new_deal(
         deal_id,
-        design_status="uploaded",
+        retrofit_design_status="uploaded",
     )
 
     assert (
@@ -270,6 +270,76 @@ def test_pashub_trigger__coordination_design_lodgement_not_completed_and_pashub_
     )
 
 
+# ==========================
+# MAGICPLAN TRIGGER TESTS
+# ==========================
+
+
+def test_magicplan_trigger__transitions_to_coordination_complete__returns_true() -> None:
+    deal_id = uuid.uuid4()
+
+    # Arrange
+    old_deal = make_old_deal(id=deal_id, coordination_status="in progress")
+    new_deal = make_new_deal(
+        deal_id,
+        **{"coordination_status__stage_1_": "(v1) ioe/mtp complete"},
+    )
+
+    # Act
+    result = HubspotDealDiffer.check_for_magicplan_trigger(
+        new_deal=new_deal,
+        old_deal=old_deal,
+    )
+
+    # Assert
+    assert result is True
+
+
+def test_magicplan_trigger__already_in_coordination_complete_unrelated_change__returns_false() -> None:
+    deal_id = uuid.uuid4()
+
+    # Arrange
+    old_deal = make_old_deal(
+        id=deal_id,
+        coordination_status="(v1) ioe/mtp complete",
+        outcome="pending",
+    )
+    new_deal = make_new_deal(
+        deal_id,
+        **{"coordination_status__stage_1_": "(v1) ioe/mtp complete"},
+        outcome="won",
+    )
+
+    # Act
+    result = HubspotDealDiffer.check_for_magicplan_trigger(
+        new_deal=new_deal,
+        old_deal=old_deal,
+    )
+
+    # Assert
+    assert result is False
+
+
+def test_magicplan_trigger__transitions_to_non_complete_coordination_status__returns_false() -> None:
+    deal_id = uuid.uuid4()
+
+    # Arrange
+    old_deal = make_old_deal(id=deal_id, coordination_status="in progress")
+    new_deal = make_new_deal(
+        deal_id,
+        **{"coordination_status__stage_1_": "design submitted"},
+    )
+
+    # Act
+    result = HubspotDealDiffer.check_for_magicplan_trigger(
+        new_deal=new_deal,
+        old_deal=old_deal,
+    )
+
+    # Assert
+    assert result is False
+
+
 # =======================
 # DB UPDATE TRIGGER TESTS
 # =======================