junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Air-source heat-pump overrides drag the conservative Group 2 control (2201) 🟥

Browse source 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-07-03 14:18:16 +00:00
parent 7a99c7eccb
commit 6d414c7b51
1 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
tests/domain/epc/test_main_heating_system_overlay.py
View file

@ -95,17 +95,34 @@ def test_electric_room_heaters_overlay_the_room_heater_charge_control() -> None:
def test_overlay_logs_when_it_cannot_complete_a_companion_set(
caplog: pytest.LogCaptureFixture,
) -> None:
# An archetype the overlay cannot yet fully companion — here an air-source
# heat pump, whose Table 4e Group 2 conservative control is not yet mapped —
# An archetype the overlay cannot yet fully companion — here community
# heating, whose Table 4e Group 3 conservative control is not yet mapped —
# is still overlaid (log-and-continue), but the incomplete companion set is
# logged as an error so the known gap is visible (CloudWatch) rather than
# silently inheriting the replaced system's stale value.
# Act
with caplog.at_level(logging.ERROR):
main_heating_overlay_for("Air source heat pump", 0)
main_heating_overlay_for("Community heating, boilers", 0)
# Assert — the gap is reported and names the archetype.
assert "Air source heat pump" in caplog.text
assert "Community heating, boilers" in caplog.text
def test_air_source_heat_pump_drags_the_conservative_group_2_control() -> None:
# The landlord names the system, not its control, so the overlay assumes
# the conservative Table 4e Group 2 default: 2201 ("no time or thermostatic
# control", +0.3 C — the largest Group 2 adjustment, so an unobserved
# control is never over-credited; the heat-pump mirror of storage 2401 /
# boiler 2101). Deliberately NOT the ASHP Measure's 2210 zone control —
# a measure designs a modern end-state (ADR-0024); an override describes an
# existing pump (ADR-0053).
# Act
simulation = main_heating_overlay_for("Air source heat pump", 0)
# Assert — SAP Table 4e Group 2 conservative heat-pump control.
assert simulation is not None
assert simulation.heating is not None
assert simulation.heating.main_heating_control == 2201
def test_complete_room_heater_overlay_does_not_log_a_companion_gap(