junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Electric boiler and CPSU overrides stamp the Table 4a boiler category (2) 🟥

Browse source 
Supersedes the "direct-acting electric drags no control/category" pin:
None does not mean unset — it means inherit the replaced system's value
(ADR-0048 bug class), verified suppressing HHRSH on portfolio 796.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-07-03 14:04:56 +00:00
parent 0f091e3ab1
commit 6d8139e47e
1 changed files with 19 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
tests/domain/epc/test_main_heating_system_overlay.py
View file

@ -434,14 +434,27 @@ def test_storage_heaters_drag_along_conservative_manual_charge_control(
assert simulation.heating.main_heating_category == 7
def test_direct_acting_electric_does_not_drag_along_a_control() -> None:
# Charge control is a storage concept and full boiler controls are a wet-
# system concept; direct-acting electric panel heaters take neither, so the
# overlay leaves the control untouched.
simulation = main_heating_overlay_for("Direct-acting electric", 0)
@pytest.mark.parametrize(
"main_heating_value",
["Direct-acting electric", "Electric boiler", "Electric CPSU"],
)
def test_electric_boiler_overlays_the_boiler_category(
main_heating_value: str,
) -> None:
# A system-replacing override must stamp the boiler heating category (SAP
# Table 4a Category 2 — codes 191/192 are wet electric boilers). Leaving it
# unset inherits the replaced system's: on portfolio 796, 30 of the first
# 40 live 191/192 overrides carried an inherited category — 6 (community)
# or 4 (heat pump) suppressed the HHRSH pathway entirely, and 7 (storage)
# made the Table 12a resolver bill direct-acting heat 100% at the off-peak
# low rate (ADR-0052, #1444).
# Act
simulation = main_heating_overlay_for(main_heating_value, 0)
# Assert — SAP Table 4a Category 2 (boiler system).
assert simulation is not None
assert simulation.heating is not None
assert simulation.heating.main_heating_control is None
assert simulation.heating.main_heating_category == 2
@pytest.mark.parametrize(