junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Slice S0380.123: pin Table U5 share-column solar fluxes at exact equality

Browse source 
`test_ne_and_nw_share_table_u5_constants` asserts NE == NW, E == W,
SE == SW orientation-pairs share the same flux value per Appendix U
Table U5's column-sharing convention. The cascade looks up both via
the same dictionary key — the values are bit-identical, not
approximately equal. Tightened from `pytest.approx(..., abs=0.01)` to
exact `==` equality; abs=0.01 masked the fact that the cascade
returns the same float object.

Net pyright: unchanged.
Tests: 17 pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-05-30 21:46:22 +00:00 • committed by Jun-te Kim
parent 07720e909e
commit 7162cb158a
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
domain/sap10_calculator/worksheet/tests/test_solar_gains.py
View file

@ -232,9 +232,11 @@ def test_ne_and_nw_share_table_u5_constants() -> None:
sw = surface_solar_flux_w_per_m2(orientation=Orientation.SW, pitch_deg=90.0, region=0, month=4)
# Assert
assert ne == pytest.approx(nw, abs=0.01)
assert e == pytest.approx(w, abs=0.01)
assert se == pytest.approx(sw, abs=0.01)
# Table U5 column-sharing — values are identical (same dictionary
# lookup), not approximately equal. Pin at exact equality.
assert ne == nw
assert e == w
assert se == sw
def test_window_solar_gain_applies_equation_5() -> None: