From 73b6fb2b70727532edec9d1a37e5210a27e23d8d Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Fri, 26 Jul 2024 15:54:07 +0100 Subject: [PATCH] notes on extension recommendations --- etl/xml_survey_extraction/XmlParser.py | 5 ++++- etl/xml_survey_extraction/app.py | 3 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/etl/xml_survey_extraction/XmlParser.py b/etl/xml_survey_extraction/XmlParser.py index 3301b0be..8391314a 100644 --- a/etl/xml_survey_extraction/XmlParser.py +++ b/etl/xml_survey_extraction/XmlParser.py @@ -345,7 +345,10 @@ class XmlParser: def get_insulation_wall_area(self): """ Extracts the insulation wall area for the main dwelling - :return: + + Note that this doesn't include any extensions. We don't have recommendations for extensions right now, so we + don't currently calculate the insulation wall area for them, since it's not used in the recommendations. + """ main_dwelling_floors = [ diff --git a/etl/xml_survey_extraction/app.py b/etl/xml_survey_extraction/app.py index edebbece..9a813216 100644 --- a/etl/xml_survey_extraction/app.py +++ b/etl/xml_survey_extraction/app.py @@ -55,6 +55,9 @@ def main(): # separate. We should use this information to make recommendations that are specific to each building # part, though the problem here is that while the fabric and dimensions are separate, the actual SAP, CO2, etc # figures span across the entire property. + # Idea: We can collect all of this information by building part and store it separately in the database + # against the uprn. We can have key data for the EPC, but then also additional data for each building + # part. We can then use this data to make recommendations that are specific to each building part # For each property, we download the xmls and extract the data database_data = []