in policies - reference s3 buckets from the defined modules instead of hardcoding bucket names

This commit is contained in:
Daniel Roth 2026-03-05 09:57:33 +00:00
parent dad4d6d55c
commit 770e19c599
2 changed files with 16 additions and 11 deletions

View file

@ -67,8 +67,14 @@ module "lambda" {
)
}
# Policies and IAM
### Policies and IAM
# S3
resource "aws_iam-role_policy_attachment" "engine_s3_read_and_write" {
role = module.lambda.role_name
policy_arn = data.terraform_remote_state.shared.outputs.engine_s3_read_and_write_arn
}
}
# Logs
# SQS

View file

@ -473,15 +473,14 @@ module "engine_s3_read_and_write" {
policy_name = "EngineReadandWriteS3"
policy_description = "Allow Engine Lambda to read from and write to various S3 buckets"
bucket_arns = [
"arn:aws:s3:::retrofit-plan-inputs-${var.stage}",
"arn:aws:s3:::retrofit-data-${var.stage}",
"arn:aws:s3:::retrofit-sap-predictions-${var.stage}",
"arn:aws:s3:::retrofit-carbon-predictions-${var.stage}",
"arn:aws:s3:::retrofit-heat-predictions-${var.stage}",
"arn:aws:s3:::retrofit-carbon-predictions-${var.stage}",
"arn:aws:s3:::retrofit-heating-kwh-predictions-${var.stage}",
"arn:aws:s3:::retrofit-hotwater-kwh-predictions-${var.stage}",
"arn:aws:s3:::retrofit-energy-assessments-${var.stage}"
"arn:aws:s3:::${module.s3_presignable_bucket.bucket_name}",
"arn:aws:s3:::${module.retrofit_sap_data.bucket_name}",
"arn:aws:s3:::${module.retrofit_sap_predictions.bucket_name}",
"arn:aws:s3:::${module.retrofit_carbon_predictions.bucket_name}",
"arn:aws:s3:::${module.retrofit_heat_predictions.bucket_name}",
"arn:aws:s3:::${module.retrofit_heating_kwh_predictions.bucket_name}",
"arn:aws:s3:::${module.retrofit_hotwater_kwh_predictions.bucket_name}",
"arn:aws:s3:::${module.retrofit_energy_assessments.bucket_name}"
]
actions = ["s3:*"]
resource_paths = ["/*"]