From 7adcad3ee6772e89b09a94f849ee6b47cf099ab4 Mon Sep 17 00:00:00 2001 From: Daniel Roth Date: Mon, 1 Jun 2026 15:11:35 +0000 Subject: [PATCH] =?UTF-8?q?`get=5Fevidence=5Ffiles=5Fby=5Fjob=5Fid`=20retu?= =?UTF-8?q?rns=20`DownloadedFiles`=20with=20empty=20`other`=20when=20`incl?= =?UTF-8?q?ude=5Fother=3DFalse`=20=F0=9F=9F=A9?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- backend/pashub_fetcher/pashub_client.py | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/backend/pashub_fetcher/pashub_client.py b/backend/pashub_fetcher/pashub_client.py index 0234d0af..084d4344 100644 --- a/backend/pashub_fetcher/pashub_client.py +++ b/backend/pashub_fetcher/pashub_client.py @@ -83,7 +83,28 @@ class PashubClient: def get_evidence_files_by_job_id( self, job_id: str, include_other: bool = False ) -> DownloadedFiles: - raise NotImplementedError + logger.info(f"Getting evidence files for job ID {job_id}") + evidence_list: List[EvidenceFileData] = self._get_evidence_list(job_id) + logger.info(f"Found {len(evidence_list)} evidence files") + if not evidence_list: + return DownloadedFiles(core=[], other=[]) + + grouped = self._group_into_core_and_other_files(evidence_list) + + core_paths: List[str] = [] + for _, evidence in grouped.core.items(): + if not evidence.file_id: + continue + metadata: EvidenceMetadata = self._get_evidence_metadata( + job_id, evidence.file_id + ) + download_url: str = self._build_download_url(metadata, evidence.file_id) + file_path: str = os.path.join("/tmp", evidence.file_name) + self._download_file(download_url, file_path) + logger.info("Successfully downloaded file") + core_paths.append(file_path) + + return DownloadedFiles(core=core_paths, other=[]) def get_uprn_by_job_id(self, job_id: str) -> Optional[str]: logger.info(f"Getting UPRN for job ID {job_id}")