junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-27 23:35:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Int-code the surveyed secondary-heating label to its Table 4a room-heater code 🟥

Browse source 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-07-15 00:25:20 +00:00
parent 390a818587
commit 7b04a9d5f4
1 changed files with 56 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

56
datatypes/epc/domain/tests/test_from_site_notes.py
View file

@ -726,6 +726,62 @@ class TestWallConstructionCoding:
EpcPropertyDataMapper.from_site_notes(survey)
class TestSecondaryHeatingTypeCoding:
"""`from_site_notes` must int-code the PAS Hub secondary-heating
`secondary_system` label to the SAP 10.2 Table 4a room-heater code, not
pass the raw string through. `_secondary_efficiency` does
`_int_or_none(secondary_heating_type)` — a string yields None and
silently falls back to code 693 (portable electric heater, eff 1.00),
so a gas open fire (code 605, eff 0.40) is billed as 100%-efficient
electric. 70/205 cohort properties lodge a secondary system; the 3
gas/solid-fuel room heaters (e.g. deal 499607224524, +4.0 SAP) were
over-credited by the wrong fallback.
"""
@pytest.mark.parametrize(
"label, expected_code",
[
# Electric direct-acting (PCDB 691, eff 1.00) — the modal cohort
# heater; 691 == the old 693 fallback efficiency, so unchanged.
("Panel, convector or radiant heaters", 691),
# Gas room heaters (PCDB Table 4a column A).
(
"Flush fitting live fuel effect open front fire, "
"sealed to fireplace",
605,
),
(
"1980 or later - Open front fire with open flue, "
"sealed to fireplace",
603,
),
# Solid fuel (PCDB 631, eff 0.32 col B).
("Open fire in grate", 631),
("No Secondary Heating", None), # no secondary heater lodged
("", None), # no lodging
],
)
def test_label_maps_to_sap_code(
self, label: str, expected_code: Optional[int]
) -> None:
data = load("pashub_rdsap_site_notes_example1.json")
data["heating_and_hot_water"]["secondary_heating"][
"secondary_system"
] = label
survey = from_dict(PasHubRdSapSiteNotes, data)
result = EpcPropertyDataMapper.from_site_notes(survey)
assert result.sap_heating.secondary_heating_type == expected_code
def test_unknown_label_strict_raises(self) -> None:
data = load("pashub_rdsap_site_notes_example1.json")
data["heating_and_hot_water"]["secondary_heating"][
"secondary_system"
] = "Wood-burning stove with heat battery"
survey = from_dict(PasHubRdSapSiteNotes, data)
with pytest.raises(UnmappedPasHubLabel):
EpcPropertyDataMapper.from_site_notes(survey)
class TestSecondaryFuelTypeCoding:
"""`from_site_notes` must int-code the PAS Hub secondary-heating
`secondary_fuel` label to the SAP 10.2 Table 32 `secondary_fuel_type`