From 7dbeffe8c4c71d1a8749824f3deb83627fde76fe Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Thu, 22 Jun 2023 19:17:50 +0100 Subject: [PATCH] Added todo --- model_data/recommendations/WallRecommendations.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/model_data/recommendations/WallRecommendations.py b/model_data/recommendations/WallRecommendations.py index b50a3646..c447288d 100644 --- a/model_data/recommendations/WallRecommendations.py +++ b/model_data/recommendations/WallRecommendations.py @@ -256,6 +256,10 @@ class WallRecommendations(BaseUtility): if self.property.walls["thermal_transmittance_unit"] != self.U_VALUE_UNIT: raise NotImplementedError("Haven't handled the case of other u value units yet") + # TODO: It's worth thinking about this logic because depending on when properties were built, + # they're likely to be of a certain standard. E.g. properties built within a certain time + # period are likely to have cavity walls + if (not is_cavity_wall) and (self.year_built >= self.YEAR_WALLS_BUILT_WITH_INSULATION) and ( u_value >= self.BUILDING_REGULATIONS_PART_L_MAX_U_VALUE ):