From 7ef08b1778143337830f082db9338cad177c5858 Mon Sep 17 00:00:00 2001
From: Khalim Conn-Kowlessar <kconnkowlessar@gmail.com>
Date: Wed, 16 Oct 2024 20:50:20 +0100
Subject: [PATCH] fixed bug in creation of simulation data

---
 etl/epc/generate_scenarios_data.py | 15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/etl/epc/generate_scenarios_data.py b/etl/epc/generate_scenarios_data.py
index fb3177a24..06d0e3771 100644
--- a/etl/epc/generate_scenarios_data.py
+++ b/etl/epc/generate_scenarios_data.py
@@ -3,6 +3,7 @@ import itertools
 from tqdm import tqdm
 
 import pandas as pd
+
 from etl.epc.Record import EPCRecord
 from etl.bill_savings.KwhData import KwhData
 from backend.SearchEpc import SearchEpc
@@ -1257,6 +1258,12 @@ scenario_properties = [
                 {},
                 [0, 1, 2]
             ],
+            [
+                ["internal_wall_insulation"],
+                "12",
+                {},
+                [0, 1, 2]
+            ],
         ],
     },
 ]
@@ -1387,7 +1394,7 @@ for scenario_property in tqdm(scenario_properties):
 
         if "low_energy_lighting" in measure:
             for rec in led_recommendations:
-                if rec["type"] == "led_lighting":
+                if rec["type"] == "low_energy_lighting":
                     lighting_recs.append(rec)
 
         if "suspended_floor_insulation" in measure:
@@ -1473,11 +1480,11 @@ sap_impact = sap_impact[
 
 # Get some metrics - MAPE for local testing
 mae = mean_absolute_error(sap_impact["actual_post_sap"], sap_impact["predicted_post_sap"])
-# 1.6828571428571433
+# 1.6511627906976745
 mape = mean_absolute_percentage_error(sap_impact["actual_post_sap"], sap_impact["predicted_post_sap"])
-# 0.02510877585853886
+# 0.02493675525723527
 mape_impact = mean_absolute_percentage_error(sap_impact["actual_impact"], sap_impact["predicted_impact"])
-# 0.35805350998208146
+# 0.34215659663334086
 
 save_dataframe_to_s3_parquet(
     recommendations_scoring_data,