From 813d51e9f311ad7902466d46f4b5f98cf5d1cbae Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Tue, 4 Jun 2024 10:05:05 +0100 Subject: [PATCH] handle the case of no hhr heater recommendation --- recommendations/Mds.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/recommendations/Mds.py b/recommendations/Mds.py index 9fe3ff09..b03a52d3 100644 --- a/recommendations/Mds.py +++ b/recommendations/Mds.py @@ -244,10 +244,16 @@ class Mds: recs = self.heating_recommender.recommend_hhr_storage_heaters( phase=phase, system_change=True, heating_controls_only=False, _return=True ) - recs = self.insert_recommendation_id(recs, measures, "high_heat_retention_storage_heaters") - mds_recommendations.append(recs) - if self.optimise_measures and len(recs): - phase += 1 + if recs is None: + logger.info( + f"No recommendations for high heat retention storage heaters, current heating " + f"{self.property_instance.main_heating['clean_description']}" + ) + else: + recs = self.insert_recommendation_id(recs, measures, "high_heat_retention_storage_heaters") + mds_recommendations.append(recs) + if self.optimise_measures and len(recs): + phase += 1 if "low_energy_lighting" in measure_config_list: raise Exception("check me out 9")