From 8294a80fdfd05be346ffcef8d38331ba5744b2a4 Mon Sep 17 00:00:00 2001 From: Jun-te Kim Date: Fri, 13 Mar 2026 15:12:43 +0000 Subject: [PATCH] change the way the tests are ran as i don't like makefile --- .github/workflows/unit_tests.yml | 18 ++++++++---------- Makefile | 30 ------------------------------ 2 files changed, 8 insertions(+), 40 deletions(-) delete mode 100644 Makefile diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml index cc6431b8..91ca7e26 100644 --- a/.github/workflows/unit_tests.yml +++ b/.github/workflows/unit_tests.yml @@ -14,17 +14,15 @@ jobs: - name: Checkout code uses: actions/checkout@v4 - - name: Set up Python 3.11 - uses: actions/setup-python@v4 - with: - python-version: '3.11' + - name: Build test image + run: docker build -f Dockerfile.test -t model-test . - - name: Install tox via Makefile - run: | - make setup - - - name: Run tests with tox via Makefile + - name: Run tests env: EPC_AUTH_TOKEN: ${{ secrets.DEV_EPC_AUTH_TOKEN }} + run: | - make test \ No newline at end of file + docker run --rm \ + -e EPC_AUTH_TOKEN=${{ secrets.DEV_EPC_AUTH_TOKEN }} \ + -e HUBSPOT_API_KEY=${{ secrets.HUBSPOT_API_KEY }} \ + model-test pytest diff --git a/Makefile b/Makefile deleted file mode 100644 index 00942acd..00000000 --- a/Makefile +++ /dev/null @@ -1,30 +0,0 @@ -# Project Makefile - -PYTHON = python - -.PHONY: setup test lint typecheck check clean - -# Install dev dependencies + tox -setup: - $(PYTHON) -m pip install --upgrade pip - $(PYTHON) -m pip install tox black ruff mypy - -# Run tests (pass ARGS="..." for specific tests) -test: - tox -- $(ARGS) - -# Code formatting check + linting -lint: - ruff . - black --check . - -# Static type checks -typecheck: - mypy . - -# Full quality check (all checks + tests) -check: lint typecheck test - -# Clean up tox environments -clean: - rm -rf .tox