junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

test(modelling): un-xfail the system-built EWI/IWI pin (#1177 resolved)

Browse source 
The merged per-cert-mapper-validation work disambiguates Elmhurst 'SY System
build' from 'B Basement wall' (both lodged wall_construction=6), so
main_wall_is_basement is no longer wrongly True for system-built and the
solid-wall generator offers EWI+IWI. The strict xfail now XPASSes; drop the
marker so it stands as a real green cascade pin.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-06-05 10:06:08 +00:00
parent f33bb9d52d
commit 82cb30ee65
1 changed files with 0 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tests/domain/modelling/test_elmhurst_cascade_pins.py
View file

@ -17,8 +17,6 @@ from __future__ import annotations
from dataclasses import replace
from typing import Final
import pytest
from datatypes.epc.domain.epc_property_data import (
BuildingPartIdentifier,
EpcPropertyData,
@ -177,16 +175,6 @@ def test_solid_brick_generator_offers_ewi_and_iwi_each_pinning_its_after() -> No
)
@pytest.mark.xfail(
strict=True,
reason="Blocked on Hestia-Homes/Model#1177 — the calculator-side "
"wall_construction=6 collision: "
"Elmhurst 'SY System build' and 'B Basement wall' both map to 6 "
"(mapper.py:2100), so `main_wall_is_basement` is wrongly True for "
"system-built and the generator's basement guard suppresses it. Flips "
"green once system-built is disambiguated from basement (MAIN "
"wall_construction==6 with main_wall_is_basement False).",
)
def test_system_built_generator_offers_ewi_and_iwi_each_pinning_its_after() -> None:
# Arrange — system-built (precast concrete) takes both Options like solid
# brick (ADR-0019): one uninsulated before, two re-lodged afters.