From 8ecd3e4bafebcbcc224c77383a9ed4aa3d95eb10 Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Wed, 18 Sep 2024 11:18:38 +0100 Subject: [PATCH] fixed the heating and heating controls unit tests --- .../test_data/heating_recommendations_data.py | 49 +++++++++++-------- 1 file changed, 29 insertions(+), 20 deletions(-) diff --git a/recommendations/tests/test_data/heating_recommendations_data.py b/recommendations/tests/test_data/heating_recommendations_data.py index e073ac99..8697e095 100644 --- a/recommendations/tests/test_data/heating_recommendations_data.py +++ b/recommendations/tests/test_data/heating_recommendations_data.py @@ -253,7 +253,7 @@ testing_examples = [ "heating_recommendation_descriptions": [ ], "heating_controls_recommendation_descriptions": [ - 'upgrade heating controls to Room thermostat, programmer and TRVs', + 'Upgrade heating controls to Room thermostat, programmer and TRVs', 'Upgrade heating controls to Smart Thermostats, room sensors and smart radiator valves (time & ' 'temperature zone control)' ], @@ -354,7 +354,7 @@ testing_examples = [ 'scheme grant' ], "heating_controls_recommendation_descriptions": [ - 'upgrade heating controls to Room thermostat, programmer and TRVs', + 'Upgrade heating controls to Room thermostat, programmer and TRVs', 'Upgrade heating controls to Smart Thermostats, room sensors and smart radiator valves (time & ' 'temperature zone control)' @@ -405,10 +405,10 @@ testing_examples = [ 'uprn-source': 'Address Matched', 'sheating-energy-eff': None, 'sheating-env-eff': None }, "heating_recommendation_descriptions": [ - 'Upgrade to a new condensing boiler. upgrade heating controls to Room thermostat, programmer and TRVs', - 'Install high heat retention electric storage heaters. upgrade heating controls to High Heat Retention ' + 'Upgrade to a new condensing boiler. Upgrade heating controls to Room thermostat, programmer and TRVs', + 'Install high heat retention electric storage heaters. Upgrade heating controls to High Heat Retention ' 'Storage Heater Controls', - 'Upgrade to a new condensing boiler. upgrade heating controls to Smart Thermostats, room sensors and smart ' + 'Upgrade to a new condensing boiler. Upgrade heating controls to Smart Thermostats, room sensors and smart ' 'radiator valves (time & temperature zone control)' ], "heating_controls_recommendation_descriptions": [], @@ -456,11 +456,14 @@ testing_examples = [ "heating_recommendation_descriptions": [ 'Install an air source heat pump, and upgrade heating controls to Smart Thermostats, room sensors and ' 'smart radiator valves (time & temperature zone control). The cost includes the £7500 boiler upgrade ' - 'scheme grant' + 'scheme grant', + 'Install high heat retention electric storage heaters. Upgrade heating controls to High Heat Retention ' + 'Storage Heater Controls' + ], "heating_controls_recommendation_descriptions": [], "notes": "This property has an oil boiler and doesn't have a mains gas connection so we can only recommend" - "an air source heat pump" + "an air source heat pump and HHR (since if the home has a non-gas boiler, we recommend HHR)" }, { "epc": { @@ -503,16 +506,18 @@ testing_examples = [ 'uprn-source': 'Address Matched', 'sheating-energy-eff': None, 'sheating-env-eff': None }, "heating_recommendation_descriptions": [ - 'Upgrade to a new condensing boiler. upgrade heating controls to Room thermostat, programmer and TRVs', - 'Upgrade to a new condensing boiler. Upgrade heating controls to Smart Thermostats, room sensors and smart ' - 'radiator valves (time & temperature zone control)', + 'Upgrade to a new condensing boiler. Upgrade heating controls to Room thermostat, programmer and TRVs', + 'Install high heat retention electric storage heaters. Upgrade heating controls to High Heat Retention ' + 'Storage Heater Controls', 'Install an air source heat pump, and upgrade heating controls to Smart Thermostats, room sensors and ' 'smart radiator valves (time & temperature zone control). The cost includes the £7500 boiler upgrade ' - 'scheme grant' + 'scheme grant', + 'Upgrade to a new condensing boiler. Upgrade heating controls to Smart Thermostats, room sensors and ' + 'smart radiator valves (time & temperature zone control)' ], "heating_controls_recommendation_descriptions": [], "notes": "This property has room heaters, from the mains gas supply. We recommend a boiler upgrade as" - "well as an air source heat pump" + "well as an air source heat pump and HHR (since the home has a room heater set up)" }, { "epc": { @@ -554,17 +559,15 @@ testing_examples = [ }, "heating_recommendation_descriptions": [ - 'Upgrade to a new condensing boiler. upgrade heating controls to Room thermostat, programmer and TRVs', + 'Upgrade to a new condensing boiler. Upgrade heating controls to Room thermostat, programmer and TRVs', 'Upgrade to a new condensing boiler. Upgrade heating controls to Smart Thermostats, room sensors and smart ' 'radiator valves (time & temperature zone control)', 'Install high heat retention electric storage heaters. Upgrade heating controls to High Heat Retention ' 'Storage Heater Controls', - 'Install an air source heat pump, and upgrade heating controls to Smart Thermostats, room sensors and ' - 'smart radiator valves (time & temperature zone control). The cost includes the £7500 boiler upgrade ' - 'scheme grant' ], "heating_controls_recommendation_descriptions": [], - "notes": "This property has assumed electric heaters. Boiler upgrade, HHR and ASHP are all recommended" + "notes": "This property has assumed electric heaters. Boiler upgrade, HHR are recommended. We don't recommend" + "an ASHP off of the bat because it's mid-terrace." }, { "epc": { @@ -1100,9 +1103,12 @@ testing_examples = [ 'may be retrofit with high heat retention storage controls however this is dependent on the existing ' 'system and may not be possible. Upgrade heating controls to High Heat Retention Storage Heater Controls' ], - "heating_controls_recommendation_descriptions": [], + "heating_controls_recommendation_descriptions": [ + 'Upgrade heating controls to Smart Thermostats, room sensors and smart radiator valves (time & ' + 'temperature zone control)' + ], "notes": "This property has dual heating. A boiler and electric storage heaters. The heating is efficient so" - "we recommend ASHP and HHR" + "we recommend ASHP and HHR. We also recommend upgrading the heating controls for the boiler" }, { "epc": { @@ -1152,7 +1158,10 @@ testing_examples = [ 'may be retrofit with high heat retention storage controls however this is dependent on the existing ' 'system and may not be possible. Upgrade heating controls to High Heat Retention Storage Heater Controls' ], - "heating_controls_recommendation_descriptions": [], + "heating_controls_recommendation_descriptions": [ + 'Upgrade heating controls to Smart Thermostats, room sensors and smart radiator valves (time & ' + 'temperature zone control)' + ], "notes": "This property is a modified version of the previous dual heating property, where we lower the" "starting heating efficiency so that we a combined heating upgrade to both the boiler and the electric" "storage heaters"