From 8ff29603c326bc2b5ef2f472b79b5daa945e7ba9 Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Mon, 7 Oct 2024 11:05:36 +0100 Subject: [PATCH] adding measure type to solar unit tests --- .../tests/test_solar_pv_recommendations.py | 27 +++++++------------ 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/recommendations/tests/test_solar_pv_recommendations.py b/recommendations/tests/test_solar_pv_recommendations.py index 05349f9c..a18291e5 100644 --- a/recommendations/tests/test_solar_pv_recommendations.py +++ b/recommendations/tests/test_solar_pv_recommendations.py @@ -3,12 +3,6 @@ from recommendations.SolarPvRecommendations import SolarPvRecommendations from backend.Property import Property from etl.epc.Record import EPCRecord import pandas as pd -from datetime import datetime -from utils.s3 import read_dataframe_from_s3_parquet, read_from_s3 -from etl.solar.SolarPhotoSupply import SolarPhotoSupply -from recommendations.Recommendations import Recommendations -from backend.ml_models.api import ModelApi -import msgpack class TestSolarPvRecommendations: @@ -86,9 +80,10 @@ class TestSolarPvRecommendations: def test_valid_all_conditions(self, property_instance_valid_all): solar_pv = SolarPvRecommendations(property_instance_valid_all) solar_pv.recommend(phase=0) + assert len(solar_pv.recommendation) == 2 assert solar_pv.recommendation == [ { - 'phase': 0, 'parts': [], 'type': 'solar_pv', + 'phase': 0, 'parts': [], 'type': 'solar_pv', 'measure_type': 'solar_pv', 'description': 'Install a 4.0 kilowatt-peak (kWp) solar photovoltaic (PV) panel system on 50% the ' 'roof.', 'starting_u_value': None, 'new_u_value': None, 'sap_points': None, 'already_installed': False, @@ -97,17 +92,13 @@ class TestSolarPvRecommendations: 'description_simulation': {'photo-supply': 50.0} }, { - 'phase': 0, 'parts': [], 'type': 'solar_pv', - 'description': 'Install a 4.0 kilowatt-peak (kWp) ' - 'solar photovoltaic (PV) panel system ' - 'on 50% the roof, with a battery ' - 'storage system.', - 'starting_u_value': None, 'new_u_value': None, - 'sap_points': None, 'already_installed': False, - 'total': 7550.0, 'subtotal': 6291.666666666667, - 'vat': 1258.333333333333, 'labour_hours': 48, - 'labour_days': 2, 'photo_supply': 50.0, - 'has_battery': True, 'initial_ac_kwh_per_year': 3800, + 'phase': 0, 'parts': [], 'type': 'solar_pv', 'measure_type': 'solar_pv', + 'description': 'Install a 4.0 kilowatt-peak (kWp) solar photovoltaic (PV) panel system on 50% the ' + 'roof, ' + 'with a battery storage system.', + 'starting_u_value': None, 'new_u_value': None, 'sap_points': None, 'already_installed': False, + 'total': 7550.0, 'subtotal': 6291.666666666667, 'vat': 1258.333333333333, 'labour_hours': 48, + 'labour_days': 2, 'photo_supply': 50.0, 'has_battery': True, 'initial_ac_kwh_per_year': 3800, 'description_simulation': {'photo-supply': 50.0} } ]