junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-27 23:35:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

A blank stored surveyor also counts as unset in the amendment check 🟥

Browse source 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Daniel Roth 2026-07-20 08:36:50 +00:00
parent b4ce0ae83f
commit 91dc359e0d
1 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
etl/hubspot/tests/test_abri_flow_triggers.py
View file

@ -174,6 +174,32 @@ def test_a_blank_surveyor_on_a_booked_deal_with_no_stored_surveyor_is_not_a_chan
assert message is None
def test_a_blank_stored_surveyor_and_a_missing_incoming_one_are_not_a_change() -> None:
# Arrange: booking exists; DB stored "" for the surveyor, HubSpot omits it.
old_deal = make_old_deal(
project_code=ABRI_PROJECT_CODE,
confirmed_survey_date=datetime(2026, 6, 24, tzinfo=timezone.utc),
confirmed_survey_time="14:30",
third_party_surveyor_identifier="",
)
new_deal = make_new_deal(
confirmed_survey_date="2026-06-24",
confirmed_survey_time="14:30",
)
# Act
message = HubspotDealDiffer.check_abri_triggers_and_construct_message(
hubspot_deal_id=DEAL_ID,
new_deal=new_deal,
new_project=None,
new_listing=LISTING,
old_deal=old_deal,
)
# Assert
assert message is None
def test_an_unchanged_surveyor_on_a_booked_deal_fires_nothing() -> None:
# Arrange: booking exists; surveyor and appointment are unchanged.
old_deal = make_old_deal(