From 93915efd9d6e0f65cb624c515586c8d5af4a911b Mon Sep 17 00:00:00 2001
From: Daniel Roth <daniel_roth@hotmail.co.uk>
Date: Thu, 12 Mar 2026 12:02:55 +0000
Subject: [PATCH] ensure pip install runs before zip by moving the install
 command to lambda_with_api_gateway

---
 .../terraform/lambda/fast-api/main.tf         | 22 +------------------
 .../modules/lambda_with_api_gateway/main.tf   | 13 +++++++++++
 .../lambda_with_api_gateway/variables.tf      |  7 +++++-
 3 files changed, 20 insertions(+), 22 deletions(-)

diff --git a/infrastructure/terraform/lambda/fast-api/main.tf b/infrastructure/terraform/lambda/fast-api/main.tf
index 9e8c7c2b..4bf88720 100644
--- a/infrastructure/terraform/lambda/fast-api/main.tf
+++ b/infrastructure/terraform/lambda/fast-api/main.tf
@@ -47,27 +47,6 @@ locals {
 #   name = var.domain_name
 # }
 
-############################################
-# Install Python requirements
-############################################
-resource "null_resource" "pip_install" {
-  triggers = {
-    requirements_hash = filemd5("${path.root}/../../../../backend/app/requirements/requirements.txt")
-  }
-
-  provisioner "local-exec" {
-    command = <<EOT
-      pip install \
-        -r ${path.root}/../../../../backend/app/requirements/requirements.txt \
-        -t ${path.root}/../../../../backend/app/packages \
-        --platform manylinux2014_x86_64 \
-        --implementation cp \
-        --python-version 3.11 \
-        --only-binary=:all: \
-    EOT
-  }
-}
-
 ############################################
 # FastAPI Lambda + API Gateway
 ############################################
@@ -83,6 +62,7 @@ module "fastapi" {
   timeout     = 600
   memory_size = 512
   artifact_bucket = data.terraform_remote_state.shared.outputs.ara_fast_api_state_bucket
+  requirements_file = "${path.root}/../../../../backend/app/requirements/requirements.txt"
 
   # domain_name     = "api.${var.domain_name}"
   # certificate_arn = data.aws_ssm_parameter.certificate_arn.value
diff --git a/infrastructure/terraform/modules/lambda_with_api_gateway/main.tf b/infrastructure/terraform/modules/lambda_with_api_gateway/main.tf
index f72729e4..92c7c7f5 100644
--- a/infrastructure/terraform/modules/lambda_with_api_gateway/main.tf
+++ b/infrastructure/terraform/modules/lambda_with_api_gateway/main.tf
@@ -6,6 +6,19 @@ module "role" {
   name   = "${var.name}-lambda-${var.stage}"
 }
 
+############################################
+# Install python packages
+############################################
+resource "null_resource" "pip_install" {
+  triggers = {
+    requirements_hash = filemd5("${var.requirements_file}")
+  }
+
+  provisioner "local-exec" {
+    command = "pip install -r ${var.requirements_file} -t ${var.source_dir} --platform manylinux2014_x86_64 --implementation cp --python-version 3.11 --only-binary=:all: --upgrade"
+  }
+}
+
 ############################################
 # Zip the source code
 ############################################
diff --git a/infrastructure/terraform/modules/lambda_with_api_gateway/variables.tf b/infrastructure/terraform/modules/lambda_with_api_gateway/variables.tf
index d0d2b933..95e5acd9 100644
--- a/infrastructure/terraform/modules/lambda_with_api_gateway/variables.tf
+++ b/infrastructure/terraform/modules/lambda_with_api_gateway/variables.tf
@@ -40,4 +40,9 @@ variable "route53_zone_id" {
   type = string
   default = null
 }
-variable "artifact_bucket" { type = string }
\ No newline at end of file
+variable "artifact_bucket" { type = string }
+
+variable "requirements_file" {
+  type    = string
+  default = null
+}
\ No newline at end of file