From 960130b00010a8d0392be012dcc70da2bf0d0223 Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Tue, 26 May 2026 13:03:29 +0000 Subject: [PATCH] deleted redundant packages folder --- packages/README.md | 16 ---------------- packages/domain/README.md | 30 ------------------------------ packages/domain/pyproject.toml | 16 ---------------- 3 files changed, 62 deletions(-) delete mode 100644 packages/README.md delete mode 100644 packages/domain/README.md delete mode 100644 packages/domain/pyproject.toml diff --git a/packages/README.md b/packages/README.md deleted file mode 100644 index 0911a1d3..00000000 --- a/packages/README.md +++ /dev/null @@ -1,16 +0,0 @@ -# Shared packages - -Workspace packages consumed by `services/*`. Each package is its own Python distribution with its own `pyproject.toml`; services import via the workspace dependency mechanism (`{ workspace = true }`). - -| Package | Purpose | -|---------|---------| -| [`domain/`](./domain/) | Shared domain types — `Property`, `BaselinePerformance`, `Plan`, `Scenario`, `EpcPropertyData`, etc. No persistence, no IO, no business logic. | -| [`repos/`](./repos/) | Persistence layer — one repo per aggregate. Owns the SQL. Depends on `domain`. | -| [`fetchers/`](./fetchers/) | External API clients (gov EPC, Ofgem, Google Solar, etc.). Depend on `domain` for response shapes. | -| [`utils/`](./utils/) | Cross-cutting infra — logging, S3, CloudWatch URL builders, SQS task helpers. | - -## Adding a new shared package - -Only when a real second consumer materialises. Don't pre-shatter (`repos-epc`, `repos-property`, ...) — split when a deployment needs to drop a dep, not before. - -See [`../ara_backend_design.md`](../ara_backend_design.md) §11 for the broader monorepo layout and [`../CONTEXT.md`](../CONTEXT.md) for the domain glossary that names the types living in `domain/`. diff --git a/packages/domain/README.md b/packages/domain/README.md deleted file mode 100644 index 6dc69d41..00000000 --- a/packages/domain/README.md +++ /dev/null @@ -1,30 +0,0 @@ -# domna-domain - -Shared domain types — `Property`, `Properties`, `BaselinePerformance`, `Plan`, `PlanPhase`, `Scenario`, `ScenarioPhase`, `ScenarioSnapshot`, `Recommendation`, `OptimisedPackage`, `EpcPropertyData`, etc. - -**Boundary**: types only. No persistence, no IO, no business logic. Other packages and services depend on `domna-domain`; this package depends on nothing internal. - -Domain definitions live in [`../../CONTEXT.md`](../../CONTEXT.md). New types added here must match the glossary terms. - -## Layout - -``` -src/domain/ -├── __init__.py -├── property.py # Property, Properties, PropertyIdentity -├── site_notes.py -├── landlord_overrides.py -├── baseline_performance.py # lodged + effective pair (ADR-0004) -├── plan.py # Plan, PlanPhase, OptimisedPackage -├── scenario.py # Scenario, ScenarioPhase, ScenarioSnapshot (ADR-0005) -├── recommendation.py -├── geospatial.py -├── solar.py -├── anomaly_flags.py -└── ml/ - ├── __init__.py - ├── transform.py # EpcMlTransform (versioned per §8.3) - └── schema.py -``` - -When `datatypes/epc/domain/` folds in, the EPC schema types move under `src/domain/epc/`. diff --git a/packages/domain/pyproject.toml b/packages/domain/pyproject.toml deleted file mode 100644 index 19786eed..00000000 --- a/packages/domain/pyproject.toml +++ /dev/null @@ -1,16 +0,0 @@ -[project] -name = "domna-domain" -version = "0.1.0" -description = "Shared domain types for the Ara modelling pipeline and sibling Domna services." -requires-python = ">=3.11" -dependencies = [ - "pandas>=2.0", - "pandas-stubs", -] - -[build-system] -requires = ["hatchling"] -build-backend = "hatchling.build" - -[tool.hatch.build.targets.wheel] -packages = ["src/domain"]