From 989cd6157405fcea2a51deed8915284dbd96507f Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Thu, 2 Jul 2026 11:04:40 +0000 Subject: [PATCH] =?UTF-8?q?ND=20loft=20roof=20on=20a=20pre-1950=20dwelling?= =?UTF-8?q?=20gets=20loft=20insulation=20=F0=9F=9F=A5?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Opus 4.8 (1M context) --- .../modelling/test_roof_recommendation.py | 24 +++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/tests/domain/modelling/test_roof_recommendation.py b/tests/domain/modelling/test_roof_recommendation.py index 3acdbb86f..77e9c0124 100644 --- a/tests/domain/modelling/test_roof_recommendation.py +++ b/tests/domain/modelling/test_roof_recommendation.py @@ -167,6 +167,30 @@ def test_vaulted_ceiling_with_measured_thickness_yields_no_recommendation() -> N assert recommendation is None +def test_loft_roof_with_nd_thickness_on_pre_1950_dwelling_yields_loft_insulation() -> None: + # Arrange — the loft fallback shares the sentinel semantics (ADR-0047): + # "ND" on an age-band-C pitched loft resolves to as-built uninsulated, so + # the joist measure fires just as it does for an explicit 0. + baseline: EpcPropertyData = build_epc() + main: SapBuildingPart = _part(baseline, BuildingPartIdentifier.MAIN) + main.roof_insulation_thickness = "ND" + main.construction_age_band = "C" + + # Act + recommendation: Recommendation | None = recommend_roof_insulation( + baseline, _StubProducts() + ) + + # Assert + assert recommendation is not None + option = recommendation.options[0] + assert option.measure_type == "loft_insulation" + simulated: EpcPropertyData = apply_simulations(baseline, [option.overlay]) + assert ( + _part(simulated, BuildingPartIdentifier.MAIN).roof_insulation_thickness == 300 + ) + + def test_loft_option_carries_cost_from_roof_area_and_product() -> None: # Arrange baseline: EpcPropertyData = build_epc() # MAIN roof area 14.85 m^2