junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fixed test and variable renames in function

Browse source
This commit is contained in:
Khalim Conn-Kowlessar 2026-02-23 15:33:32 +00:00
parent 694717bd34
commit 9dda6fb434
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
recommendations/optimiser/optimiser_functions.py
View file

@ -424,4 +424,4 @@ def check_needs_ventilation(
x in property_measure_types for x in measures_needing_ventilation
)
return needs_ventilation and not has_ventilation and ventilation_included
return needs_ventilation and not property_already_has_ventilation and ventilation_in_included_measures

6
recommendations/tests/test_optimiser_functions.py
View file

@ -143,7 +143,9 @@ class TestAddBestPracticeMeasures:
]
}
selected = set()
updated = optimiser_functions.add_best_practice_measures(property_id, solution, recommendations, selected)
updated = optimiser_functions.add_best_practice_measures(
property_id, solution, recommendations, selected, True
)
assert "vent1" in updated
assert "trickle1" in updated
@ -273,7 +275,7 @@ class TestIncreasingEpcE2e:
total_optimised_gain = sum(m["gain"] for m in solution)
assert total_optimised_gain == 17.6, "Total gain of optimised measures should meet or exceed target gain"
selected = optimiser_functions.add_best_practice_measures(p.id, solution, recommendations, selected)
selected = optimiser_functions.add_best_practice_measures(p.id, solution, recommendations, selected, False)
# Flatten recommendations for output
flattened = optimiser_functions.flatten_recommendations_with_defaults(p.id, recommendations, selected)