junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Construct sap_ventilation in from_rdsap_schema_19_0 / 21_0_0 🟩

Browse source 
Both passed no sap_ventilation= → EpcPropertyData default None, dropping the
whole §2 block so MEV/MVHR certs scored as natural. Mirror 21.0.1's block for
the only fields each schema lodges: mechanical_ventilation_kind (§2 MV-kind
dispatch) + sheltered_sides (§S5, from built_form). Neither schema lodges the
fan/flue/vent counts (RdSAP Table-5 age defaults), so those stay unset.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-06-26 09:55:08 +00:00
parent 34d97a75f4
commit a63276387e
1 changed files with 26 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
datatypes/epc/domain/mapper.py
View file

@ -1698,6 +1698,19 @@ class EpcPropertyDataMapper:
if getattr(bp, "glazed_perimeter", None) is None if getattr(bp, "glazed_perimeter", None) is None
], ],
sap_conservatory=_api_sap_conservatory(schema.sap_building_parts), sap_conservatory=_api_sap_conservatory(schema.sap_building_parts),
# ADR-0037 follow-up: 19.0 previously passed no `sap_ventilation=`,
# dropping the whole §2 block. The schema only lodges the top-level
# `mechanical_ventilation` enum + `built_form` (no fan/flue/vent
# counts — RdSAP uses Table-5 age defaults), so mirror just those
# two fields from 21.0.1. An MEV/MVHR cert that defaulted to NATURAL
# under-stated its ventilation heat loss; `sheltered_sides` (§S5)
# avoids the cascade's shelter default of 2.
sap_ventilation=SapVentilation(
sheltered_sides=_api_sheltered_sides(schema.built_form),
mechanical_ventilation_kind=_api_mechanical_ventilation_kind(
schema.mechanical_ventilation
),
),
) )
@staticmethod @staticmethod
@ -2274,6 +2287,19 @@ class EpcPropertyDataMapper:
else None else None
), ),
), ),
# ADR-0037 follow-up: 21.0.0 previously passed no `sap_ventilation=`,
# dropping the whole §2 block. Unlike 21.0.1 it does not lodge the
# fan/flue/vent counts, so mirror only the two fields it does carry:
# the top-level `mechanical_ventilation` enum (→ §2 MV-kind dispatch;
# an MEV/MVHR cert otherwise defaulted to NATURAL and under-stated
# ventilation heat loss) and `sheltered_sides` from built_form (§S5,
# vs the cascade's shelter default of 2).
sap_ventilation=SapVentilation(
sheltered_sides=_api_sheltered_sides(schema.built_form),
mechanical_ventilation_kind=_api_mechanical_ventilation_kind(
schema.mechanical_ventilation
),
),
) )
@staticmethod @staticmethod