junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Set main_heating on the test_validation partial EPC builder 🟩

Browse source 
The heating-donor display synthesis reads donor.epc.main_heating, which has no
dataclass default — so a partial object.__new__ EpcPropertyData must set it.
test_validation's _comparable builder didn't, failing the two leave-one-out
scorer tests in CI (the full epc_prediction suite wasn't run pre-push).
main_heating_controls / sap_ventilation default to None via class attributes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-06-26 12:35:01 +00:00
parent 5fc8bd3b3d
commit ac94a543b1
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/domain/epc_prediction/test_validation.py
View file

@ -64,6 +64,10 @@ def _comparable(
heating.cylinder_insulation_type = 1 heating.cylinder_insulation_type = 1
heating.secondary_heating_type = None heating.secondary_heating_type = None
epc.sap_heating = heating epc.sap_heating = heating
# Display heating rows the heating-donor synthesis carries (ADR-0029
# follow-up); `main_heating` has no dataclass default, so a partial instance
# must set it. `main_heating_controls` / `sap_ventilation` default to None.
epc.main_heating = []
energy: SapEnergySource = object.__new__(SapEnergySource) energy: SapEnergySource = object.__new__(SapEnergySource)
energy.photovoltaic_supply = None energy.photovoltaic_supply = None
energy.photovoltaic_arrays = None energy.photovoltaic_arrays = None