junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-30 13:10:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #537 from Hestia-Homes/main

Browse source 
handled failure case for descriptions to fuel types and added a note to fix this in the future
This commit is contained in:
KhalimCK 2025-11-07 23:35:08 +00:00 • committed by GitHub
commit b0ab15bb01
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
backend/app/assumptions.py
View file

@ -79,6 +79,7 @@ DESCRIPTIONS_TO_FUEL_TYPES = {
"fuel": "Electricity", "cop": AVERAGE_ASHP_EFFICIENCY / 100 "fuel": "Electricity", "cop": AVERAGE_ASHP_EFFICIENCY / 100
}, },
"Electric heat pump for water heating only": {"fuel": "Electricity", "cop": 1}, "Electric heat pump for water heating only": {"fuel": "Electricity", "cop": 1},
"Ground source heat pump, warm air, electric": {"fueld": "Electricity", "cop": AVERAGE_ASHP_EFFICIENCY / 100},
} }
# These are the measure types where if there is a ventilation recommendation, we force the inclusion of it # These are the measure types where if there is a ventilation recommendation, we force the inclusion of it

6
recommendations/Recommendations.py
View file

@ -688,7 +688,11 @@ class Recommendations:
} }
raise NotImplementedError("Handle this case") raise NotImplementedError("Handle this case")
mapped = descriptions_to_fuel_types[heating_description] mapped = descriptions_to_fuel_types.get(heating_description, None)
if mapped is None:
# TODO: This is a non-ideal placeholder but we put something in place for a process that falls over
# fairly regularly. A task has been added to planner to refactor this
mapped = {"fuel": 'Unmapped', "cop": 0.9}
heating_fuel = mapped["fuel"] heating_fuel = mapped["fuel"]
if hotwater_description in [ if hotwater_description in [