From c7c208334e231568449acb714a42b12d0e47405d Mon Sep 17 00:00:00 2001 From: Jun-te Kim Date: Mon, 16 Feb 2026 16:54:35 +0000 Subject: [PATCH 1/3] lets view plan for now --- .github/workflows/deploy_terraform.yml | 1 + infrastructure/terraform/lambda/address2UPRN/main.tf | 2 ++ infrastructure/terraform/modules/sqs_queue/main.tf | 2 +- infrastructure/terraform/modules/sqs_queue/variables.tf | 7 ++++++- 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy_terraform.yml b/.github/workflows/deploy_terraform.yml index e7c8fb94..c7a3ec1b 100644 --- a/.github/workflows/deploy_terraform.yml +++ b/.github/workflows/deploy_terraform.yml @@ -52,6 +52,7 @@ jobs: runs-on: ubuntu-latest env: STAGE: ${{ needs.determine_stage.outputs.stage }} + TERRAFORM_APPLY: ${{ needs.determine_stage.outputs.terraform_apply }} steps: - uses: actions/checkout@v4 diff --git a/infrastructure/terraform/lambda/address2UPRN/main.tf b/infrastructure/terraform/lambda/address2UPRN/main.tf index 5a36153e..f53d55c8 100644 --- a/infrastructure/terraform/lambda/address2UPRN/main.tf +++ b/infrastructure/terraform/lambda/address2UPRN/main.tf @@ -22,6 +22,8 @@ module "address2uprn" { image_uri = local.image_uri + timeout = 900 + environment = merge( { STAGE = var.stage diff --git a/infrastructure/terraform/modules/sqs_queue/main.tf b/infrastructure/terraform/modules/sqs_queue/main.tf index 580e67bd..356d3429 100644 --- a/infrastructure/terraform/modules/sqs_queue/main.tf +++ b/infrastructure/terraform/modules/sqs_queue/main.tf @@ -5,7 +5,7 @@ resource "aws_sqs_queue" "dlq" { resource "aws_sqs_queue" "this" { name = var.name - visibility_timeout_seconds = 120 + visibility_timeout_seconds = var.timeout * 6 redrive_policy = jsonencode({ deadLetterTargetArn = aws_sqs_queue.dlq.arn diff --git a/infrastructure/terraform/modules/sqs_queue/variables.tf b/infrastructure/terraform/modules/sqs_queue/variables.tf index 943a7a16..bb8e4485 100644 --- a/infrastructure/terraform/modules/sqs_queue/variables.tf +++ b/infrastructure/terraform/modules/sqs_queue/variables.tf @@ -2,5 +2,10 @@ variable "name" { type = string } variable "max_receive_count" { type = number - default = 5 + default = 1 +} + +variable "timeout" { + type = number + default = 900 } From 952a2cb2c0df65bf4c58c62e68c5a2d7d7a516f3 Mon Sep 17 00:00:00 2001 From: Jun-te Kim Date: Mon, 16 Feb 2026 17:23:15 +0000 Subject: [PATCH 2/3] quick shared infra --- .github/workflows/deploy_terraform.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/deploy_terraform.yml b/.github/workflows/deploy_terraform.yml index c7a3ec1b..c6937f7a 100644 --- a/.github/workflows/deploy_terraform.yml +++ b/.github/workflows/deploy_terraform.yml @@ -3,7 +3,9 @@ name: Deploy infrastructure on: push: branches: - - "**" + - "main" + - "dev" + - "prod" paths: - 'infrastructure/terraform/**' - '.github/workflows/deploy_terraform.yml' From 0afa8b3aba6993d45a35336ce0f878eb56e32faa Mon Sep 17 00:00:00 2001 From: Jun-te Kim Date: Mon, 16 Feb 2026 17:29:10 +0000 Subject: [PATCH 3/3] sqs time out redploy --- infrastructure/terraform/modules/sqs_queue/main.tf | 2 +- infrastructure/terraform/modules/sqs_queue/variables.tf | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/infrastructure/terraform/modules/sqs_queue/main.tf b/infrastructure/terraform/modules/sqs_queue/main.tf index 356d3429..afb7dc27 100644 --- a/infrastructure/terraform/modules/sqs_queue/main.tf +++ b/infrastructure/terraform/modules/sqs_queue/main.tf @@ -5,7 +5,7 @@ resource "aws_sqs_queue" "dlq" { resource "aws_sqs_queue" "this" { name = var.name - visibility_timeout_seconds = var.timeout * 6 + visibility_timeout_seconds = 1000 redrive_policy = jsonencode({ deadLetterTargetArn = aws_sqs_queue.dlq.arn diff --git a/infrastructure/terraform/modules/sqs_queue/variables.tf b/infrastructure/terraform/modules/sqs_queue/variables.tf index bb8e4485..95b33231 100644 --- a/infrastructure/terraform/modules/sqs_queue/variables.tf +++ b/infrastructure/terraform/modules/sqs_queue/variables.tf @@ -4,8 +4,3 @@ variable "max_receive_count" { type = number default = 1 } - -variable "timeout" { - type = number - default = 900 -}