junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1022 from Hestia-Homes/feature/pashub-to-ara

Browse source 
Pashub to Ara: correct hubspot deal differ logic
This commit is contained in:
Daniel Roth 2026-04-21 15:19:46 +01:00 • committed by GitHub
commit b1f287b0c0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
etl/hubspot/hubspot_deal_differ.py
View file

@ -166,7 +166,7 @@ class HubspotDealDiffer:
@staticmethod
def _design_completed(new_deal: Dict[str, str], old_deal: HubspotDealData) -> bool:
new_status: str = new_deal.get("coordination_status") or ""
new_status: str = new_deal.get("design_status") or ""
return (
new_status != ""
and new_status.lower() == HubspotDealDiffer.RETROFIT_DESIGN_COMPLETE
@ -177,7 +177,7 @@ class HubspotDealDiffer:
def _lodgement_completed(
new_deal: Dict[str, str], old_deal: HubspotDealData
) -> bool:
new_status: str = new_deal.get("coordination_status") or ""
new_status: str = new_deal.get("lodgement_status") or ""
return (
new_status != ""
and new_status.lower() in HubspotDealDiffer.LODGEMENT_COMPLETE

4
etl/hubspot/tests/test_hubspot_deal_differ.py
View file

@ -90,8 +90,8 @@ def test_pashub_trigger__pashub_link_changed__returns_true(
@pytest.mark.parametrize(
"coordination_status,expected",
[
("v1 ioe/mtp complete", True),
("v2 ioe/mtp complete", True),
("(v1) ioe/mtp complete", True),
("(v2) ioe/mtp complete", True),
],
)
def test_pashub_trigger__coordination_completed_and_pashub_link_set__returns_true(