junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-08 11:17:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

completed recommendation logic

Browse source
This commit is contained in:
Khalim Conn-Kowlessar 2023-06-22 10:49:01 +01:00
parent c4087b6124
commit b867297c8d
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
model_data/recommendations/WallRecommendations.py
View file

@ -261,8 +261,11 @@ class WallRecommendations:
if is_solid_brick and insulation_thickness == "none":
# This is an estimated figure based on industry standards
u_value = self.DEFAULT_U_VALUES["solid_brick"]
if insulation_thickness == "none":
# This is an estimated figure based on industry standards
u_value = self.DEFAULT_U_VALUES["solid_brick"]
else:
u_value = self._get_walls_uvalue_estimate()
ewi_parts = [
part for part in wall_parts if part["type"] == "external_wall_insulation"
@ -291,6 +294,7 @@ class WallRecommendations:
)
# We also can recommend both internal and external wall insulation together
# By looping through ewi first, if there is nothing there, that ensures not combinations are tested
for ewi_part in ewi_parts:
for iwi_part in iwi_parts:
for ewi_depth, iwi_depth in itertools.product(ewi_part["depths"], iwi_part["depths"]):
@ -318,14 +322,6 @@ class WallRecommendations:
]
self.recommendations.append(recommendation)
if is_solid_brick and insulation_thickness == "average" and wall_energy_efficiency in ["Good", "Average"]:
# Get uvalue estimate
uvalue_estimate = self._get_walls_uvalue_estimate()
if self.property.in_conservation_area == ConservationAreaClient.IN_CONSERVATION_AREA:
blah
raise NotImplementedError("Not implemented yet")
def _get_walls_uvalue_estimate(self):