junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-27 23:35:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Re-pin 6035 golden fixture for terraced RR-gable reclassification

Browse source 
6035 is built_form 4 (Mid-Terrace), so this PR routes its Exposed Type-1
RR gable to a party gable (U=0.25) instead of the main-wall U. Heat loss
drops: PE resid -0.14 -> -0.92, CO2 -0.0362 -> -0.0549 (SAP still exact 70).
Residuals stay within noise (PE <0.5% of lodged 191). All 113 golden
fixtures pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Khalim Conn-Kowlessar 2026-07-17 14:38:42 +00:00
parent 85fe51b623
commit ba90624a02
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
tests/domain/sap10_calculator/rdsap/test_golden_fixtures.py
View file

@ -306,8 +306,8 @@ _EXPECTATIONS: tuple[_GoldenExpectation, ...] = (
cert_number="6035-7729-2309-0879-2296",
actual_sap=70,
expected_sap_resid=+0,
expected_pe_resid_kwh_per_m2=-0.1357,
expected_co2_resid_tonnes_per_yr=-0.0362,
expected_pe_resid_kwh_per_m2=-0.9246,
expected_co2_resid_tonnes_per_yr=-0.0549,
notes=(
"Mid-terrace, TFA 128, age A, gas combi Table 4b code 104. "
"S0380.189 fixed the dominant driver: walls are solid brick "
@ -367,7 +367,16 @@ _EXPECTATIONS: tuple[_GoldenExpectation, ...] = (
"PE +1.37 → -0.14, CO2 -0.0004 → -0.0362 (SAP still exact 70). "
"Validated against the simulated-case-6 worksheet, the only "
"worksheet evidence for 'Roof of Room' rooflight deduction "
"(6035's site-notes case-4 replica lodges no rooflights)."
"(6035's site-notes case-4 replica lodges no rooflights). "
"This PR (terraced RR-gable reclassification) re-pins PE/CO2: "
"6035 is built_form 4 (Mid-Terrace), so both RR gables are "
"party (RdSAP 10 §1.4.3) — the mapper now routes its Exposed "
"Type-1 gable to gable_wall (U=0.25) instead of the main-wall "
"U. Heat loss drops → PE -0.14 → -0.92, CO2 -0.0362 → -0.0549 "
"(SAP still exact 70). Residuals stay well within noise (PE "
"<0.5% of lodged 191); corroborated by three accredited "
"Elmhurst mid-terrace worksheets (000477/000480/000516) that "
"all lodge RR gables as Party."
),
),
_GoldenExpectation(