From bb5e8376cd8e9c27fc058b1fecf0af7aae8a5814 Mon Sep 17 00:00:00 2001
From: Khalim Conn-Kowlessar <kconnkowlessar@gmail.com>
Date: Mon, 30 Sep 2024 16:19:07 +0100
Subject: [PATCH] fixed roof recommendations tests

---
 .../tests/test_roof_recommendations.py        | 43 ++++++++++---------
 1 file changed, 22 insertions(+), 21 deletions(-)

diff --git a/recommendations/tests/test_roof_recommendations.py b/recommendations/tests/test_roof_recommendations.py
index 3d555a4f..e7a4c540 100644
--- a/recommendations/tests/test_roof_recommendations.py
+++ b/recommendations/tests/test_roof_recommendations.py
@@ -28,9 +28,10 @@ class TestRoofRecommendations:
 
         assert not roof_recommender.recommendations
 
-        roof_recommender.recommend()
+        roof_recommender.recommend(phase=0)
 
-        assert len(roof_recommender.recommendations)
+        assert len(roof_recommender.recommendations) == 1
+        assert roof_recommender.recommendations[0]["parts"][0]["depth"] == 300
 
     def test_loft_insulation_recommendation_50mm_insulation(self):
         epc_record = EPCRecord()
@@ -52,13 +53,14 @@ class TestRoofRecommendations:
 
         assert not roof_recommender2.recommendations
 
-        roof_recommender2.recommend()
+        roof_recommender2.recommend(phase=0)
 
         assert len(roof_recommender2.recommendations) == 1
 
-        assert roof_recommender2.recommendations[0]["total"] == 1936.9206000000004
+        assert roof_recommender2.recommendations[0]["total"] == 1610.0000000000002
         assert roof_recommender2.recommendations[0]["new_u_value"] == 0.14
         assert roof_recommender2.recommendations[0]["starting_u_value"] == 0.68
+        assert roof_recommender2.recommendations[0]["parts"][0]["depth"] == 270
 
         epc_record = EPCRecord()
         epc_record.prepared_epc = {"county": "Greater London Authority"}
@@ -79,7 +81,7 @@ class TestRoofRecommendations:
 
         assert not roof_recommender3.recommendations
 
-        roof_recommender3.recommend()
+        roof_recommender3.recommend(phase=0)
 
         assert roof_recommender3.recommendations
         assert len(roof_recommender3.recommendations) == 1
@@ -105,14 +107,14 @@ class TestRoofRecommendations:
 
         assert not roof_recommender4.recommendations
 
-        roof_recommender4.recommend()
+        roof_recommender4.recommend(phase=0)
 
-        assert len(roof_recommender4.recommendations) == 4
+        assert len(roof_recommender4.recommendations) == 1
 
-        assert roof_recommender4.recommendations[0]["total"] == 1128.744
-        assert roof_recommender4.recommendations[0]["new_u_value"] == 0.15
+        assert roof_recommender4.recommendations[0]["total"] == 1552.5
+        assert roof_recommender4.recommendations[0]["new_u_value"] == 0.13
         assert roof_recommender4.recommendations[0]["starting_u_value"] == 0.3
-        assert roof_recommender4.recommendations[0]["parts"][0]["depth"] == 150
+        assert roof_recommender4.recommendations[0]["parts"][0]["depth"] == 200
 
         epc_record = EPCRecord()
         epc_record.prepared_epc = {"county": "Somerset"}
@@ -133,12 +135,11 @@ class TestRoofRecommendations:
 
         assert not roof_recommender5.recommendations
 
-        roof_recommender5.recommend()
+        roof_recommender5.recommend(phase=0)
 
-        # The 150mm insulation should be selected, since there it already 150mm
         assert roof_recommender5.recommendations
-        assert len(roof_recommender5.recommendations) == 4
-        assert roof_recommender5.recommendations[0]["parts"][0]["depth"] == 150
+        assert len(roof_recommender5.recommendations) == 1
+        assert roof_recommender5.recommendations[0]["parts"][0]["depth"] == 200
 
     def test_loft_insulation_recommendation_270mm_insulation(self):
         # We shouldn't recommend anything in this case
@@ -161,7 +162,7 @@ class TestRoofRecommendations:
 
         assert not roof_recommender6.recommendations
 
-        roof_recommender6.recommend()
+        roof_recommender6.recommend(phase=0)
 
         assert len(roof_recommender6.recommendations) == 0
 
@@ -302,12 +303,12 @@ class TestRoofRecommendations:
 
         assert not roof_recommender11.recommendations
 
-        roof_recommender11.recommend()
+        roof_recommender11.recommend(phase=0)
 
         assert len(roof_recommender11.recommendations) == 1
 
         assert roof_recommender11.recommendations[0]["parts"][0]["depth"] == 150
-        assert roof_recommender11.recommendations[0]["total"] == 4380.84324
+        assert roof_recommender11.recommendations[0]["total"] == 6532.5
         assert roof_recommender11.recommendations[0]["new_u_value"] == 0.14
         assert roof_recommender11.recommendations[0]["starting_u_value"] == 2.3
         assert roof_recommender11.recommendations[0]["description"] == \
@@ -334,7 +335,7 @@ class TestRoofRecommendations:
 
         assert not roof_recommender12.recommendations
 
-        roof_recommender12.recommend()
+        roof_recommender12.recommend(phase=0)
 
         assert not roof_recommender12.recommendations
 
@@ -358,13 +359,13 @@ class TestRoofRecommendations:
 
         assert not roof_recommender13.recommendations
 
-        roof_recommender13.recommend()
+        roof_recommender13.recommend(phase=0)
 
         assert len(roof_recommender13.recommendations) == 1
 
         assert roof_recommender13.recommendations[0]["parts"][0]["depth"] == 150
 
-        assert roof_recommender13.recommendations[0]["total"] == 5199.969120000002
+        assert roof_recommender13.recommendations[0]["total"] == 7800
         assert roof_recommender13.recommendations[0]["new_u_value"] == 0.14
         assert roof_recommender13.recommendations[0]["starting_u_value"] == 2.3
 
@@ -390,6 +391,6 @@ class TestRoofRecommendations:
 
         assert not roof_recommender14.recommendations
 
-        roof_recommender14.recommend()
+        roof_recommender14.recommend(phase=0)
 
         assert not roof_recommender14.recommendations