junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-12 13:29:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Abri survey creation trigger ignores syncs with no parseable confirmed_survey_date 🟥

Browse source 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Daniel Roth 2026-07-02 16:02:08 +00:00
parent fb2b7e164c
commit c059771af5
1 changed files with 35 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

35
etl/hubspot/tests/test_hubspot_deal_differ.py
View file

@ -448,6 +448,41 @@ def test_abri_survey_creation__project_code_cased_differently__returns_true() ->
assert result is True
@pytest.mark.parametrize(
"new_overrides",
[
{},
{"confirmed_survey_date": ""},
{"confirmed_survey_date": "not-a-date"},
],
)
def test_abri_survey_creation__no_parseable_new_date__returns_false(
new_overrides: Dict[str, str],
) -> None:
deal_id = uuid.uuid4()
# Arrange
old_deal = make_old_deal(
id=deal_id,
project_code="Abri Condition",
confirmed_survey_date=None,
)
new_deal = make_new_deal(
deal_id,
project_code="Abri Condition",
**new_overrides,
)
# Act
result = HubspotDealDiffer.check_for_abri_survey_creation(
new_deal=new_deal,
old_deal=old_deal,
)
# Assert
assert result is False
# =======================
# DB UPDATE TRIGGER TESTS
# =======================