From c116adf3c01587bbca75283fca557ac61b085db2 Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Sat, 24 Jun 2023 22:50:08 +0100 Subject: [PATCH] minor --- model_data/recommendations/FloorRecommendations.py | 2 ++ model_data/recommendations/WallRecommendations.py | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/model_data/recommendations/FloorRecommendations.py b/model_data/recommendations/FloorRecommendations.py index 1a20c432..a9ee8387 100644 --- a/model_data/recommendations/FloorRecommendations.py +++ b/model_data/recommendations/FloorRecommendations.py @@ -27,6 +27,8 @@ class FloorRecommendations(BaseUtility): self.property.data["floor-energy-eff"] self.property.data["floor-env-eff"] + # TODO: We neeed to know if the property is ground floor or not + if self.property.floor["another_property_below"]: # If there's another property below, it's likely impractical to recommend a floor upgrade return diff --git a/model_data/recommendations/WallRecommendations.py b/model_data/recommendations/WallRecommendations.py index 7db865b0..e1c05f5c 100644 --- a/model_data/recommendations/WallRecommendations.py +++ b/model_data/recommendations/WallRecommendations.py @@ -209,6 +209,10 @@ class WallRecommendations(BaseUtility): # we still consider it as an option U_VALUE_ERROR = 0.01 + # TODO: Review this value against RdSAP + # Page 19 of rdsap here: + # https://files.bregroup.com/bre-co-uk-file-library-copy/filelibrary/SAP/2012/RdSAP-9.93/RdSAP_2012_9.93.pdf + # provides default U-values for solid brick walls depending on age band DEFAULT_U_VALUES = { "solid_brick": 2, }