From c431453d75fa5374cbab183b9816cb0728195bca Mon Sep 17 00:00:00 2001 From: Khalim Conn-Kowlessar Date: Tue, 2 Jun 2026 14:05:57 +0000 Subject: [PATCH] refactor(fuel-rates): name the adapter aggregate-first per house convention MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR feedback: adapters here are __repository (e.g. property_baseline_postgres_repository). Rename the fuel-rates adapter to match — file static_file_fuel_rates_repository.py -> fuel_rates_static_file_repository.py and class StaticFileFuelRatesRepository -> FuelRatesStaticFileRepository, plus its test. git mv preserves history. Co-Authored-By: Claude Opus 4.8 --- ...ository.py => fuel_rates_static_file_repository.py} | 2 +- ...ry.py => test_fuel_rates_static_file_repository.py} | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) rename repositories/fuel_rates/{static_file_fuel_rates_repository.py => fuel_rates_static_file_repository.py} (96%) rename tests/repositories/fuel_rates/{test_static_file_fuel_rates_repository.py => test_fuel_rates_static_file_repository.py} (83%) diff --git a/repositories/fuel_rates/static_file_fuel_rates_repository.py b/repositories/fuel_rates/fuel_rates_static_file_repository.py similarity index 96% rename from repositories/fuel_rates/static_file_fuel_rates_repository.py rename to repositories/fuel_rates/fuel_rates_static_file_repository.py index cbfd5062..1f53617d 100644 --- a/repositories/fuel_rates/static_file_fuel_rates_repository.py +++ b/repositories/fuel_rates/fuel_rates_static_file_repository.py @@ -11,7 +11,7 @@ from repositories.fuel_rates.fuel_rates_repository import FuelRatesRepository _DEFAULT_SNAPSHOT = Path(__file__).parent / "data" / "fuel_rates_2026_q2.json" -class StaticFileFuelRatesRepository(FuelRatesRepository): +class FuelRatesStaticFileRepository(FuelRatesRepository): """Reads Fuel Rates from a committed JSON snapshot (ADR-0014). Only **single-rate** fuels (those lodging a ``unit_rate_p_per_kwh``) are diff --git a/tests/repositories/fuel_rates/test_static_file_fuel_rates_repository.py b/tests/repositories/fuel_rates/test_fuel_rates_static_file_repository.py similarity index 83% rename from tests/repositories/fuel_rates/test_static_file_fuel_rates_repository.py rename to tests/repositories/fuel_rates/test_fuel_rates_static_file_repository.py index 38d3a0a6..a129daf2 100644 --- a/tests/repositories/fuel_rates/test_static_file_fuel_rates_repository.py +++ b/tests/repositories/fuel_rates/test_fuel_rates_static_file_repository.py @@ -3,14 +3,14 @@ from __future__ import annotations import pytest from domain.fuel_rates.fuel import Fuel, UnpricedFuel -from repositories.fuel_rates.static_file_fuel_rates_repository import ( - StaticFileFuelRatesRepository, +from repositories.fuel_rates.fuel_rates_static_file_repository import ( + FuelRatesStaticFileRepository, ) def test_get_current_loads_the_committed_snapshot_mains_gas_rate() -> None: # Arrange - repository = StaticFileFuelRatesRepository() + repository = FuelRatesStaticFileRepository() # Act rates = repository.get_current() @@ -21,7 +21,7 @@ def test_get_current_loads_the_committed_snapshot_mains_gas_rate() -> None: def test_snapshot_prices_metered_and_delivered_fuels_plus_seg() -> None: # Arrange - rates = StaticFileFuelRatesRepository().get_current() + rates = FuelRatesStaticFileRepository().get_current() # Act / Assert — electricity carries a daily standing charge; oil is # delivered (no meter) so its standing charge is 0; SEG is a flat credit. @@ -38,7 +38,7 @@ def test_snapshot_prices_metered_and_delivered_fuels_plus_seg() -> None: def test_unpriced_fuels_raise_rather_than_defaulting(fuel: Fuel) -> None: # Arrange — house coal + heat network have no national rate, and off-peak # needs the day/night split a later slice adds (ADR-0014). - rates = StaticFileFuelRatesRepository().get_current() + rates = FuelRatesStaticFileRepository().get_current() # Act / Assert with pytest.raises(UnpricedFuel):