junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-06-30 13:10:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

map water heating cylinder size 🟥

Browse source
This commit is contained in:
Daniel Roth 2026-04-21 11:13:04 +00:00
parent b64c9d275f
commit c558b79b68
3 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
backend/documents_parser/tests/test_end_to_end.py
View file

@ -267,3 +267,6 @@ class TestPdfToEpcPropertyDataFixture2:
def test_cylinder_insulation_thickness(self, result: EpcPropertyData) -> None: def test_cylinder_insulation_thickness(self, result: EpcPropertyData) -> None:
assert result.sap_heating.cylinder_insulation_thickness_mm == 38 assert result.sap_heating.cylinder_insulation_thickness_mm == 38
def test_cylinder_size(self, result: EpcPropertyData) -> None:
assert result.sap_heating.cylinder_size == "Normal (90-130 litres)"

3
backend/documents_parser/tests/test_extractor.py
View file

@ -398,6 +398,9 @@ class TestWaterHeatingCylinderThickness:
def test_cylinder_insulation_thickness_mm_absent(self, hhw_no_cylinder: HeatingAndHotWater) -> None: def test_cylinder_insulation_thickness_mm_absent(self, hhw_no_cylinder: HeatingAndHotWater) -> None:
assert hhw_no_cylinder.water_heating.insulation_thickness_mm is None assert hhw_no_cylinder.water_heating.insulation_thickness_mm is None
def test_cylinder_size(self, hhw: HeatingAndHotWater) -> None:
assert hhw.water_heating.cylinder_size == "Normal (90-130 litres)"
class TestHeatingAndHotWater: class TestHeatingAndHotWater:
@pytest.fixture @pytest.fixture

4
datatypes/epc/domain/epc_property_data.py
View file

@ -54,8 +54,8 @@ class SapHeating:
instantaneous_wwhrs: InstantaneousWwhrs instantaneous_wwhrs: InstantaneousWwhrs
main_heating_details: List[MainHeatingDetail] main_heating_details: List[MainHeatingDetail]
has_fixed_air_conditioning: bool has_fixed_air_conditioning: bool
cylinder_size: Optional[int] = ( cylinder_size: Optional[Union[int, str]] = (
None # int code from API; not directly available from site notes None # int code from API; str (e.g. "Normal (90-130 litres)") from site notes
) )
water_heating_code: Optional[int] = None # TODO: make enum? water_heating_code: Optional[int] = None # TODO: make enum?
water_heating_fuel: Optional[int] = None # TODO: make enum? water_heating_fuel: Optional[int] = None # TODO: make enum?