junte/Model
1
0
Fork 0
mirror of https://github.com/Hestia-Homes/Model.git synced 2026-07-27 23:35:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Amend an Abri booking only on a change to a complete booking, never when logging 🟩

Browse source 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Daniel Roth 2026-07-24 15:51:38 +00:00
parent a39c008f36
commit cc23b43f40
2 changed files with 25 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
etl/hubspot/hubspot_deal_differ.py
View file

@ -358,21 +358,31 @@ class HubspotDealDiffer:
new_surveyor,
)
# A first-time survey date logs a new job, not an amendment.
if old_deal.confirmed_survey_date is None:
# Only a complete booking (both date and surveyor set now) can be
# amended; a lone field is nothing to amend, and a pair still forming
# waits for the log flow.
# TODO: a cleared survey date (was a complete booking, now not) no
# longer fires this check; the amendoptiappt route cannot express a
# cancellation, so cancellation semantics (the canceljob route) need a
# deliberate decision (existing differ TODO, issue #1478 out of scope).
if new_survey_date is None or new_surveyor is None:
return False
# TODO: a cleared survey date (was set, now empty) still fires this
# check, but the amendoptiappt route cannot express a cancellation.
# Cancellation semantics (the "delete" action / canceljob route) need
# a deliberate decision before this trigger is wired to a consumer.
if old_deal.confirmed_survey_date != new_survey_date:
return True
change_occurred = (
old_deal.confirmed_survey_date != new_survey_date
or old_deal.confirmed_survey_time != new_survey_time
or old_surveyor != new_surveyor
)
if not change_occurred:
return False
if old_deal.confirmed_survey_time != new_survey_time:
return True
# The scrape that completes the pair logs the job; it never amends one.
if HubspotDealDiffer.check_for_abri_job_logging(
new_deal=new_deal, new_project=new_project, old_deal=old_deal
):
return False
return old_surveyor != new_surveyor
return True
@staticmethod
def check_for_abri_tenant_data_fetch(

5
etl/hubspot/tests/test_abri_flow_triggers.py
View file

@ -448,15 +448,18 @@ def test_a_first_expected_commencement_date_builds_a_tenant_sync_message() -> No
def test_several_flows_firing_in_one_scrape_share_one_message() -> None:
# Arrange: date changed and commencement date first set together.
# Arrange: on a complete booking, the date changed (amend) and the
# commencement date was first set (tenant sync) together.
old_deal = make_old_deal(
project_code=ABRI_PROJECT_CODE,
confirmed_survey_date=datetime(2026, 6, 18, tzinfo=timezone.utc),
third_party_surveyor_identifier="THIRDPARTY",
expected_commencement_date=None,
)
new_deal = make_new_deal(
confirmed_survey_date="2026-06-24",
confirmed_survey_time="14:30",
third_party_surveyor_identifier="THIRDPARTY",
expected_commencement_date="2026-07-01",
)