From cdefa658879871b1e695c68c80782c306763e218 Mon Sep 17 00:00:00 2001 From: Daniel Roth Date: Fri, 5 Jun 2026 12:53:45 +0000 Subject: [PATCH] =?UTF-8?q?Reclassify=20doorglass=20wall=20items=20as=20Wi?= =?UTF-8?q?ndow=20domain=20objects=20=F0=9F=9F=A5?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-Authored-By: Claude Sonnet 4.6 --- datatypes/magicplan/domain/tests/test_mapper.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/datatypes/magicplan/domain/tests/test_mapper.py b/datatypes/magicplan/domain/tests/test_mapper.py index 09e8aa28..85467267 100644 --- a/datatypes/magicplan/domain/tests/test_mapper.py +++ b/datatypes/magicplan/domain/tests/test_mapper.py @@ -254,6 +254,14 @@ def test_window_with_no_custom_fields_has_no_ventilation() -> None: assert window.ventilation is None +def test_doorglass_is_classified_as_window(plan_new: Plan) -> None: + # Living/Dining Room (floor 0, room 1) has one doorglass wall item. + # It must appear in room.windows, not room.doors. + room = plan_new.floors[0].rooms[1] + + assert "doorglass" in [w.opening_type for w in room.windows] + + def test_toilet_door_has_ventilation_undercut(plan_new: Plan) -> None: # Toilet is floor 0 room 2; its doorhinged has Door Undercut (mm) = 70 toilet_doors = plan_new.floors[0].rooms[2].doors